Re: [PATCH] emacs: do not put quoted reply in primary selection

diff --git a/e6/1df7c911a340d21170a68093d77203980dfaca b/e6/1df7c911a340d21170a68093d77203980dfaca
new file mode 100644 (file)
index 0000000..edc1930
--- /dev/null
+++ b/e6/1df7c911a340d21170a68093d77203980dfaca
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 445F1431FD4\r
+       for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 11:42:52 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id RGcQgnavCfSy for <notmuch@notmuchmail.org>;\r
+       Sun, 17 Nov 2013 11:42:47 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 97A5A431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 17 Nov 2013 11:42:47 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 03245100030;\r
+       Sun, 17 Nov 2013 21:42:41 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: do not put quoted reply in primary selection\r
+In-Reply-To: <87siuu95uy.fsf@servo.finestructure.net>\r
+References: <1384689849-9388-1-git-send-email-markwalters1009@gmail.com>\r
+       <87siuu95uy.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.16+175~g19e97d6 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 17 Nov 2013 21:42:40 +0200\r
+Message-ID: <m2eh6e7r2n.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 17 Nov 2013 19:42:52 -0000\r
+\r
+On Sun, Nov 17 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+\r
+> On Sun, Nov 17 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>> In current emacs (24.3) select-active-regions is set to t by\r
+>> default. The reply insertion code sets the region to the quoted\r
+>> message to make it easy to delete (kill-region or C-w). These two\r
+>> things combine to put the quoted message in the primary selection.\r
+>>\r
+>> This is not what the user wanted and is a privacy risk (accidental\r
+>> pasting of the quoted message). We can avoid some of the problems\r
+>> by let-binding select-active-regions to nil. This fixes if the\r
+>> primary selection was previously in a non-emacs window but not if\r
+>> it was in an emacs window. To avoid the problem in the latter case\r
+>> we deactivate mark.\r
+>>\r
+>> One key test (which fails under many simpler "fixes") is: open emacs\r
+>> 24.3 with notmuch, open 2 windows (viewing different notmuch buffers),\r
+>> highlight some text in one, and then reply to a message in the\r
+>> other. In many of my earlier attempts to fix this big this test fails.\r
+>\r
+> I'm very happy to report that I reply to this message with an unpolluted\r
+> paste buffer!  Kudos Mark!\r
+>\r
+>> Anyway, this is the best I can manage!\r
+>\r
+> Too modest for such an achievement.\r
+>\r
+> +10\r
+\r
+This works for me too (and tests pass). \r
+\r
+I don't see how this could break thinks, So I think this is important\r
+enough th be included in 0.17 \r
+\r
+> jamie.\r
+\r
+Tomi\r