Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show...

diff --git a/4b/40befa71865c8733ea49495b5b402e66a6fa9b b/4b/40befa71865c8733ea49495b5b402e66a6fa9b
new file mode 100644 (file)
index 0000000..476c4fe
--- /dev/null
+++ b/4b/40befa71865c8733ea49495b5b402e66a6fa9b
@@ -0,0 +1,102 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0F665429E28\r
+       for <notmuch@notmuchmail.org>; Wed, 25 May 2011 15:46:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id JMptdDc3IECG for <notmuch@notmuchmail.org>;\r
+       Wed, 25 May 2011 15:46:47 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9EC78431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 25 May 2011 15:46:47 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 9181B29A4FA;\r
+       Wed, 25 May 2011 15:46:46 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 7E51B25417E; Wed, 25 May 2011 15:46:46 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown\r
+       in notmuch-show view.\r
+In-Reply-To: <87k4depfyj.fsf@gmail.com>\r
+References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 25 May 2011 15:46:40 -0700\r
+Message-ID: <87lixu9z5b.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 25 May 2011 22:46:48 -0000\r
+\r
+--=-=-=\r
+\r
+On Thu, 26 May 2011 02:34:28 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> I am not sure how it is best to test this.  The common `printc' method\r
+> for emacs tests does not work, because it prints invisible parts as\r
+> well.  We need either to find a way to print only visible text on the\r
+> console, or test it inside emacs somehow.  Any suggestions?\r
+\r
+Unfortunately, I don't have a good plan here. I delayed implementing any\r
+automated testing at all of the emacs interface precisely because of\r
+this problem. It's seems to me that surely emacs must have some built-in\r
+mechanism for copying the visible portion of a block of text, but I've\r
+not been able to find it.\r
+\r
+We could do something cheesy (and slow) by marching through the buffer\r
+character-by-character in elisp and testing for visibility, but the\r
+emacs tests are already the slowest part of "make test"[*] so that would\r
+be obnoxious.\r
+\r
+> Note that this is exactly the patch that hits the isearch emacs bug.  Do\r
+> I understand correctly that you are ready to push the series despite of\r
+> it (given that we have a test)?\r
+\r
+Breaking isearch would be really unfortunate. That's a really nice\r
+feature of the emacs frontend currently.\r
+\r
+So I would notice that breakage, (while I've apparently never before\r
+noticed the breakage of having visible citations in a hidden message).\r
+\r
+So no, I'm not saying I'm ready to push the series while emacs is broken.\r
+\r
+-Carl\r
+\r
+[*] Maybe the performance of the emacs testing could be significantly\r
+improved by sharing a single invocation of emacs? Perhaps this wouldn't\r
+even be hard by just using emacsclient?\r
+\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3dhtAACgkQ6JDdNq8qSWjhZQCgg2l2/aHq3LBhQPfsGWKHHFfj\r
+frwAnibcwJNHfY6ddcTMbguX7mADjEHb\r
+=M99J\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r