Re: [notmuch] [PATCH 1/2] Close message file after parsing message headers

diff --git a/21/a3bc613be5f8009a5d9e3d1dc14b4917cf4106 b/21/a3bc613be5f8009a5d9e3d1dc14b4917cf4106
new file mode 100644 (file)
index 0000000..d30ae7e
--- /dev/null
+++ b/21/a3bc613be5f8009a5d9e3d1dc14b4917cf4106
@@ -0,0 +1,68 @@
+Return-Path: <keithp@keithp.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F1E1A431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 13:15:30 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id iCUsOU61POSG for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Nov 2009 13:15:29 -0800 (PST)\r
+Received: from keithp.com (home.keithp.com [63.227.221.253])\r
+       by olra.theworths.org (Postfix) with ESMTP id 77B24431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Nov 2009 13:15:29 -0800 (PST)\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by keithp.com (Postfix) with ESMTP id 95C46760129;\r
+       Tue, 17 Nov 2009 13:15:28 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at keithp.com\r
+Received: from keithp.com ([127.0.0.1])\r
+       by localhost (keithp.com [127.0.0.1]) (amavisd-new, port 10024)\r
+       with LMTP id zJkWoUraovYM; Tue, 17 Nov 2009 13:15:25 -0800 (PST)\r
+Received: by keithp.com (Postfix, from userid 1033)\r
+       id 723E276012A; Tue, 17 Nov 2009 13:15:25 -0800 (PST)\r
+Received: from keithp.com (localhost [127.0.0.1])\r
+       by keithp.com (Postfix) with ESMTP id 64A17760129;\r
+       Tue, 17 Nov 2009 13:15:25 -0800 (PST)\r
+From: Keith Packard <keithp@keithp.com>\r
+To: Carl Worth <cworth@cworth.org>, Mikhail Gusarov\r
+       <dottedmag@dottedmag.net>, notmuch@notmuchmail.org\r
+In-Reply-To: <87lji5cbwo.fsf@yoom.home.cworth.org>\r
+References: <1258471718-6781-1-git-send-email-dottedmag@dottedmag.net>\r
+       <87lji5cbwo.fsf@yoom.home.cworth.org>\r
+Date: Tue, 17 Nov 2009 13:15:25 -0800\r
+Message-ID: <yunbpj0etua.fsf@aiko.keithp.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Subject: Re: [notmuch] [PATCH 1/2] Close message file after parsing message\r
+ headers\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Nov 2009 21:15:31 -0000\r
+\r
+On Tue, 17 Nov 2009 09:13:27 -0800, Carl Worth <cworth@cworth.org> wrote:\r
+\r
+> I didn't apply Keith's fix yet, because I think I'd rather just fix the\r
+> indexer to store the In-Reply-To header in a separate term prefix from\r
+> the term used for the References header[*]. That will then let us lookup\r
+> the in-reply-to value later for thread constructions without having to\r
+> open the original email file at all.\r
+\r
+Threading the message also involves displaying the from and to contents,\r
+which requires opening the message file. The alternative to the fix I\r
+provided is to just parse all of the message headers when first opening\r
+the message; it could then be immediately closed and the hash referred\r
+to for all header data. Given the choice, just having the caller say\r
+when it has finished with a message is probably a reasonable option...\r
+\r
+-keith\r