Re: [PATCH 0/6] Clean up reply's encoding story

diff --git a/7b/c89433b3c7c687a0a588d7a5f436b3931a5228 b/7b/c89433b3c7c687a0a588d7a5f436b3931a5228
new file mode 100644 (file)
index 0000000..8f34b39
--- /dev/null
+++ b/7b/c89433b3c7c687a0a588d7a5f436b3931a5228
@@ -0,0 +1,87 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2897D431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Aug 2013 10:04:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id L7nBQsy8c0bl for <notmuch@notmuchmail.org>;\r
+       Wed, 14 Aug 2013 10:04:16 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id AC2F0431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Aug 2013 10:04:16 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id B9B56100051;\r
+       Wed, 14 Aug 2013 20:04:10 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/6] Clean up reply's encoding story\r
+In-Reply-To: <1376332839-22825-1-git-send-email-amdragon@mit.edu>\r
+References: <1376332839-22825-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 14 Aug 2013 20:04:10 +0300\r
+Message-ID: <m2zjskjjat.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 14 Aug 2013 17:04:23 -0000\r
+\r
+On Mon, Aug 12 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Jeff Stedfast's email about gmime-filter-headers.c possibly being\r
+> unnecessary with GMime 2.6 (quoted in id:87bo56viyo.fsf@nikula.org)\r
+> sent me on a wild goose chase that led to this patch series.  It\r
+> turned out that we *did* need gmime-filter-headers for what we were\r
+> doing in the reply text format, but what we were doing made no sense.\r
+> Patches 1 through 4 are simply the documentation and tests that I left\r
+> in my wake and are harmless to push.  Patch 6 is my conclusion that\r
+> how we were handling header encoding in the text reply format made no\r
+> sense.  Patch 5 is a step toward patch 6, but makes sense on its own\r
+> even if we decide against patch 6.\r
+\r
+The whole series Looks Good To Me (sans known hiccups). I tested the patch 6\r
+affecting 'default' output of notmuch reply bot not json or sexp output\r
+(which I found surprising as so much code was removed). All the explations\r
+in id:1376332839-22825-7-git-send-email-amdragon@mit.edu makes good sense\r
+(but fix also 'tmeplate').\r
+\r
+A slighly related note: ^M:s ^J:s (among other chars) don't get encoded\r
+into =?utf-8?b?...?= ...\r
+\r
+... also interestingly if U+202E (LEFT-TO-RIGHT OVERRIDE) is in (at least\r
+From) header it disappears from `notmuch reply` default format. In json\r
+and sexp format it disappears in 'reply-headers' but exists in 'headers'.\r
+emacs client seems to use reply-headers as none of the header text lines\r
+in buffer is  rendered RTL.\r
+\r
+\r
+Tomi\r
+\r
+>\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r