RE: notmuch-0.21 bug report

diff --git a/79/dbfcc258d0dcb7bd3deadbfd87f91441bde3d7 b/79/dbfcc258d0dcb7bd3deadbfd87f91441bde3d7
new file mode 100644 (file)
index 0000000..ec8afc2
--- /dev/null
+++ b/79/dbfcc258d0dcb7bd3deadbfd87f91441bde3d7
@@ -0,0 +1,75 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 26E626DE00C9\r
+ for <notmuch@notmuchmail.org>; Mon, 25 Apr 2016 12:40:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.016\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.016 tagged_above=-999 required=5\r
+ tests=[AWL=-0.005, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id kWqQcrXqOwEo for <notmuch@notmuchmail.org>;\r
+ Mon, 25 Apr 2016 12:40:10 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 5A6106DE00DF\r
+ for <notmuch@notmuchmail.org>; Mon, 25 Apr 2016 12:40:09 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aumMi-0002nX-8I; Mon, 25 Apr 2016 15:40:16 -0400\r
+Received: (nullmailer pid 6093 invoked by uid 1000);\r
+ Mon, 25 Apr 2016 19:40:07 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: David Binderman <dcb314@hotmail.com>,\r
+ "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>\r
+Subject: RE: notmuch-0.21 bug report\r
+In-Reply-To: <DUB128-W40FF39685EC08E151E7E5B9C620@phx.gbl>\r
+References: <DUB128-W37A050CCA0515311F04F009C620@phx.gbl>\r
+ <87wpnlbllb.fsf@zancas.localnet>\r
+ <DUB128-W40FF39685EC08E151E7E5B9C620@phx.gbl>\r
+User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 25 Apr 2016 16:40:07 -0300\r
+Message-ID: <87shy9bhpk.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 25 Apr 2016 19:40:18 -0000\r
+\r
+David Binderman <dcb314@hotmail.com> writes:\r
+\r
+> Hello there,\r
+>\r
+> ----------------------------------------\r
+>> Hi David;\r
+>>\r
+>> Thanks for the report. fclose doesn't really make sense here; \r
+>\r
+> Surprising. There is a call to fclose for the success return,\r
+> so I just assumed that one would also be required for the error return.\r
+>\r
+\r
+Ah OK, I thought the fclose referred to the notmuch database, but it\r
+refers to the input file. So yes, there is techically a resource leakage\r
+here, but I'm not sure how important it is, since these returns are part\r
+of program shutdown. Is there any harm in having FILEs open for read\r
+when a program shuts down? On the other hand, I guess it would only take\r
+5 or 6 added lines of code if someone wanted to add our usual "goto\r
+DONE" path\r
+\r
+d\r