Re: message-default-mail-headers not working in notmuch 0.22

diff --git a/ec/c3572f850a4283a61a42b73b3271b4ffbf366e b/ec/c3572f850a4283a61a42b73b3271b4ffbf366e
new file mode 100644 (file)
index 0000000..e7fce46
--- /dev/null
+++ b/ec/c3572f850a4283a61a42b73b3271b4ffbf366e
@@ -0,0 +1,99 @@
+Return-Path: <sebastian.fischmeister@uwaterloo.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 63F0A6DE034D\r
+ for <notmuch@notmuchmail.org>; Fri, 29 Apr 2016 13:56:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.069\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.069 tagged_above=-999 required=5 tests=[AWL=0.242,\r
+  RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id yUZ49CKF7nI5 for <notmuch@notmuchmail.org>;\r
+ Fri, 29 Apr 2016 13:55:59 -0700 (PDT)\r
+Received: from mailchk-m04.uwaterloo.ca (mailservices.uwaterloo.ca\r
+ [129.97.128.141])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id D27D56DE0319\r
+ for <notmuch@notmuchmail.org>; Fri, 29 Apr 2016 13:55:58 -0700 (PDT)\r
+Received: from connect.uwaterloo.ca (connhub2.connect.uwaterloo.ca\r
+ [129.97.149.119])\r
+ by mailchk-m04.uwaterloo.ca (8.14.4/8.14.4) with ESMTP id u3TKtrAb021558\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK);\r
+ Fri, 29 Apr 2016 16:55:54 -0400\r
+Received: from uwaterloo.ca (129.97.68.117) by connhub2.connect.uwaterloo.ca\r
+ (129.97.149.119) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 29 Apr\r
+ 2016 16:55:52 -0400\r
+From: Sebastian Fischmeister <sfischme@uwaterloo.ca>\r
+To: David Edmondson <dme@dme.org>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: message-default-mail-headers not working in notmuch 0.22\r
+In-Reply-To: <m2shy4eb6z.fsf@dme.org>\r
+References: <87y47wmsfi.fsf@uwaterloo.ca> <m2shy4eb6z.fsf@dme.org>\r
+Reply-To: <sfischme@uwaterloo.ca>\r
+X-Homepage: http://esg.uwaterloo.ca\r
+Date: Fri, 29 Apr 2016 16:55:52 -0400\r
+Message-ID: <87twik9lt3.fsf@uwaterloo.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-UUID: 8f016564-773b-448e-a4e0-3245d918b654\r
+X-Miltered: at mailchk-m04 with ID 5723CA59.000 by Joe's j-chkmail\r
+ (http://j-chkmail.ensmp.fr)!\r
+X-Virus-Scanned: clamav-milter 0.99 at mailchk-m04\r
+X-Virus-Status: Clean\r
+X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.9\r
+ (mailchk-m04.uwaterloo.ca [129.97.128.141]);\r
+ Fri, 29 Apr 2016 16:55:55 -0400 (EDT)\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 29 Apr 2016 20:56:07 -0000\r
+\r
+I can confirm that this fixes the problem.\r
+\r
+Thanks for the quick reply!\r
+\r
+  Sebastian\r
+\r
+David Edmondson <dme@dme.org> writes:\r
+\r
+> On Fri, Apr 29 2016, Sebastian Fischmeister wrote:\r
+>> After upgrading to notmuch 0.22, my emacs config seems broken:\r
+>>\r
+>> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")\r
+>>\r
+>> When creating a new mail, it has no header other than "To:" and\r
+>> "Subject:".\r
+>>\r
+>> Since I cannot find any item in the NEWS related to this release, is\r
+>> this expected behaviour?\r
+>\r
+> No, it's not intended. Please try this patch:\r
+>\r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index 0445975..399e138 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -338,7 +338,10 @@ modified. This function is notmuch addaptation of\r
+>        ;; We need to convert any string input, eg from rmail-start-mail.\r
+>        (dolist (h other-headers other-headers)\r
+>          (if (stringp (car h)) (setcar h (intern (capitalize (car h))))))))\r
+> -    (args (list yank-action send-actions)))\r
+> +    (args (list yank-action send-actions))\r
+> +    ;; Cause `message-setup-1' to do things relevant for mail,\r
+> +    ;; such as observe `message-default-mail-headers'.\r
+> +    (message-this-is-mail t))\r
+>      ;; message-setup-1 in Emacs 23 does not accept return-action\r
+>      ;; argument. Pass it only if it is supplied by the caller. This\r
+>      ;; will never be the case when we're called by `compose-mail' in\r