Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro

diff --git a/8d/06cb4988724530f09c1c26990db2a31df2364a b/8d/06cb4988724530f09c1c26990db2a31df2364a
new file mode 100644 (file)
index 0000000..5656d4c
--- /dev/null
+++ b/8d/06cb4988724530f09c1c26990db2a31df2364a
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E15996DE13EF\r
+ for <notmuch@notmuchmail.org>; Tue,  8 Dec 2015 04:44:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.318\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.318 tagged_above=-999 required=5 tests=[AWL=0.233,\r
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id CJZyhYnrDSeY for <notmuch@notmuchmail.org>;\r
+ Tue,  8 Dec 2015 04:44:16 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id EF7716DE1378\r
+ for <notmuch@notmuchmail.org>; Tue,  8 Dec 2015 04:44:15 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1a6Hcn-0007Ws-1U; Tue, 08 Dec 2015 07:44:09 -0500\r
+Received: (nullmailer pid 14943 invoked by uid 1000);\r
+ Tue, 08 Dec 2015 12:44:10 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Cc: tomi.ollila@iki.fi\r
+Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro\r
+In-Reply-To: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 08 Dec 2015 08:44:10 -0400\r
+Message-ID: <87egexyusl.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 08 Dec 2015 12:44:20 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> Some compilers (older than gcc 4.5 and clang 2.9) do support\r
+> __attribute__ ((deprecated)) but not\r
+> __attribute__ ((deprecated("message"))).\r
+>\r
+> Check (clang) and know (gcc) which versions support which variants\r
+> and make two definitions of define NOTMUCH_DEPRECATED macro;\r
+> one with and and one without the ("message") part.\r
+>\r
+> __has_extension() replacement was modeled after __has_attribute()\r
+> definition in compat/function-attributes.h. Thanks Justus.\r
+\r
+Hi Tomi;\r
+\r
+I keep coming back to review this patch, but I'm blocked by the fact\r
+that clang++ is broken on Debian (and lots of other places, I guess) for\r
+months.\r
+\r
+        https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038\r
+\r
+d\r