Re: [PATCH] emacs: remove auto-signing of replies to signed messages

diff --git a/8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556 b/8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556
new file mode 100644 (file)
index 0000000..336dfd7
--- /dev/null
+++ b/8b/29b96ccc1a05fc373edbc9a97de8ef0e58e556
@@ -0,0 +1,104 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6057A431FC3\r
+       for <notmuch@notmuchmail.org>; Mon, 14 Apr 2014 12:48:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nOBOTcvn-1Jm for <notmuch@notmuchmail.org>;\r
+       Mon, 14 Apr 2014 12:48:13 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5AC02431FC0\r
+       for <notmuch@notmuchmail.org>; Mon, 14 Apr 2014 12:48:13 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9F9EC10008F;\r
+       Mon, 14 Apr 2014 22:48:08 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] emacs: remove auto-signing of replies to signed messages\r
+In-Reply-To: <1397504450-15498-1-git-send-email-jrollins@finestructure.net>\r
+References: <87mwfnd9eh.fsf@tethera.net>\r
+       <1397504450-15498-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.17+201~g56da2d6 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 14 Apr 2014 22:48:08 +0300\r
+Message-ID: <m2mwfnpu9z.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 14 Apr 2014 19:48:24 -0000\r
+\r
+On Mon, Apr 14 2014, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+\r
+> It was decided that auto-signing is potentially too troublesome for the\r
+> apparently common case of users who enable crypto processing for the\r
+> purpose of checking signature validity but who are not in a position to\r
+> sign out-going messages.  Users can still manually invoke signing as needed.\r
+>\r
+> Encrypting replies to encrypted messages is more of a security issue\r
+> so we leave it in place.\r
+> ---\r
+\r
+LGTM. Works for me. +1\r
+\r
+Tomi\r
+\r
+\r
+>  emacs/notmuch-mua.el | 7 +++----\r
+>  1 file changed, 3 insertions(+), 4 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index bf6253f..95e4a4d 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -116,10 +116,9 @@ list."\r
+>      notmuch-mua-hidden-headers))\r
+>  \r
+>  (defun notmuch-mua-reply-crypto (parts)\r
+> +  "Add mml sign-encrypt flag if any part of original message is encrypted."\r
+>    (loop for part in parts\r
+> -    if (notmuch-match-content-type (plist-get part :content-type) "multipart/signed")\r
+> -      do (mml-secure-message-sign)\r
+> -    else if (notmuch-match-content-type (plist-get part :content-type) "multipart/encrypted")\r
+> +    if (notmuch-match-content-type (plist-get part :content-type) "multipart/encrypted")\r
+>        do (mml-secure-message-sign-encrypt)\r
+>      else if (notmuch-match-content-type (plist-get part :content-type) "multipart/*")\r
+>        do (notmuch-mua-reply-crypto (plist-get part :content))))\r
+> @@ -236,7 +235,7 @@ list."\r
+>      ;; Quote the original message according to the user's configured style.\r
+>      (message-cite-original)))\r
+>  \r
+> -    ;; Sign and/or encrypt replies to signed and/or encrypted messages.\r
+> +    ;; Crypto processing based crypto content of the original message\r
+>      (when process-crypto\r
+>        (notmuch-mua-reply-crypto (plist-get original :body))))\r
+>  \r
+> -- \r
+> 1.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r