Re: [PATCH v2 08/10] cli: add insert --must-index option

diff --git a/25/f76696bcd806f0b07e7667058351d47a78a357 b/25/f76696bcd806f0b07e7667058351d47a78a357
new file mode 100644 (file)
index 0000000..f097839
--- /dev/null
+++ b/25/f76696bcd806f0b07e7667058351d47a78a357
@@ -0,0 +1,99 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 158A1431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 28 Jul 2014 07:48:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id C48eXVUFip-F for <notmuch@notmuchmail.org>;\r
+       Mon, 28 Jul 2014 07:48:09 -0700 (PDT)\r
+Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com\r
+       [209.85.192.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D8E3E431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 28 Jul 2014 07:48:08 -0700 (PDT)\r
+Received: by mail-pd0-f175.google.com with SMTP id r10so10013361pdi.20\r
+       for <notmuch@notmuchmail.org>; Mon, 28 Jul 2014 07:48:07 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:message-id:from:to:cc:subject:in-reply-to:references\r
+       :mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=GjakIT4xHsdQ1k0myv7X011SlRLwo96RvsIO+PaIcOY=;\r
+       b=urHtqR3VtZk4RXfB1091Y4Ialih0FYRuXMyP55kfFy9Wcyv+G6aWqctRHD527Ga1yG\r
+       Z6XrHm+zy1Iha5Dj8DETAcv4+lSrF2bmvf7/eCrh59nBRwdQdSgLvq5NgRoksO4BD97N\r
+       01ALpDO0KESqHNQYSHXFsZBq7ykBvbJOrLPCBb+DMe1+JY0Wpyq6ADR7wZJWAmdICmKW\r
+       Jcs1Aqca6xZCjn/VJ34mskpinCyA4u23Utf4ODMlPzZiHx2uWqQ1dyQHymMalgSgZe8c\r
+       G10pRO/FChqJnhPCKhvFQPrUfurdVGnxUAdJ7BmH9P6fWy/A7BPOjJ+9JLgS/dKfheOF\r
+       O2UQ==\r
+X-Received: by 10.66.118.71 with SMTP id kk7mr2799671pab.147.1406558886704;\r
+       Mon, 28 Jul 2014 07:48:06 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPSA id kp7sm6958905pdb.73.2014.07.28.07.48.04\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Mon, 28 Jul 2014 07:48:05 -0700 (PDT)\r
+Date: Tue, 29 Jul 2014 00:48:01 +1000\r
+Message-ID: <20140729004801.GF18000@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH v2 08/10] cli: add insert --must-index option\r
+In-Reply-To: <87wqbm86ha.fsf@maritornes.cs.unb.ca>\r
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>\r
+       <1397653165-15620-9-git-send-email-novalazy@gmail.com>\r
+       <87wqbm86ha.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 28 Jul 2014 14:48:17 -0000\r
+\r
+On Wed, 09 Jul 2014 20:20:17 -0300, David Bremner <david@tethera.net> wrote:\r
+> Peter Wang <novalazy@gmail.com> writes:\r
+> \r
+> > This option causes notmuch insert to fail (with exit code 3) on failure\r
+> > to index the message, or failure to set the tags on the message, or if\r
+> > closing (flushing) the database fails.  Failure to sync tags to flags\r
+> > has no effect.\r
+> \r
+> I don't really understand why it's OK to ignore failure to sync\r
+> flags. Can you explain? Or point to a previous discussion if we already\r
+> went through this?\r
+\r
+It wasn't really discussed.  Only Mark expressed that he didn't really\r
+mind in id:87hadtxfrr.fsf@qmul.ac.uk\r
+\r
+It might be justified that, unlike a failure to index, the message will\r
+still be found though the notmuch interface, with the tags intact.\r
+Running notmuch new will not lose those tags either (I think).\r
+It's only when you view the message through another interface that there\r
+will be an inconsistency in the small subset of tags which can be mapped\r
+to maildir flags.\r
+\r
+If we were strict about failure to sync flags, then presumably the\r
+newly-added message would need to be deleted from disk and removed from\r
+the database.  I'm not sure it's worthwhile to avoid that (minor)\r
+inconsistency.\r
+\r
+Peter\r