Re: [PATCH] Avoid empty thread names if possible.

diff --git a/43/da7236b1c42d0a2bd010dbe3213812ab691a6e b/43/da7236b1c42d0a2bd010dbe3213812ab691a6e
new file mode 100644 (file)
index 0000000..67ca089
--- /dev/null
+++ b/43/da7236b1c42d0a2bd010dbe3213812ab691a6e
@@ -0,0 +1,77 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B4F6431FC2\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 06:32:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Tq4gAlkFfe69 for <notmuch@notmuchmail.org>;\r
+       Wed, 29 Oct 2014 06:32:19 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 999B7431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 06:32:19 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A4F88100051;\r
+       Wed, 29 Oct 2014 15:32:03 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jesse Rosenthal <jrosenthal@jhu.edu>,\r
+       Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Avoid empty thread names if possible.\r
+In-Reply-To: <87a94f2fe3.fsf@jhu.edu>\r
+References: <87oatnakqy.fsf@jhu.edu> <87tx2nuvec.fsf@qmul.ac.uk>\r
+       <87a94f2fe3.fsf@jhu.edu>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 29 Oct 2014 15:32:03 +0200\r
+Message-ID: <m2bnov57e4.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Oct 2014 13:32:27 -0000\r
+\r
+On Wed, Oct 29 2014, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:\r
+\r
+> By the way, this discussion brings up another problem. I wasn't able to\r
+> write a test for this (to address the below concerns) because the test\r
+> suite for thread-naming supplies some sort of auto-generated subject\r
+> for threads with empty subjects. So we can't test behavior for dealing\r
+> with empty subjects.\r
+>\r
+> Unfortunately, I don't know the history of the test suite, or why this\r
+> auto-subject decisicion was made, so I don't feel comfortable just\r
+> changing the behavior.\r
+\r
+Autogeneration of (unique) headers when some header not given...\r
+\r
+Shell could distinguish between unset and empty variable, but that would\r
+proably make most users feel PITA to use it... (*)\r
+\r
+... probably better altelnative could be some magic word, like 'none' to\r
+make generate_message() set header in question empty (and first just\r
+implement that "feature" to Subject header.\r
+\r
+Tomi\r
+\r
+(*) personally I'd be totally comfortable with it, though ;D\r
+\r