Re: [PATCH] nmbug-status: add support for specifying sort order for each view

diff --git a/5c/482bc88ab3b15ac30c853b4e41dee6a4d28c24 b/5c/482bc88ab3b15ac30c853b4e41dee6a4d28c24
new file mode 100644 (file)
index 0000000..ff970b9
--- /dev/null
+++ b/5c/482bc88ab3b15ac30c853b4e41dee6a4d28c24
@@ -0,0 +1,104 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 59A066DE1A5E\r
+ for <notmuch@notmuchmail.org>; Mon,  6 Apr 2015 09:48:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.202\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.202 tagged_above=-999 required=5 tests=[AWL=0.550, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 1Umx1Eyd6W-W for <notmuch@notmuchmail.org>;\r
+ Mon,  6 Apr 2015 09:48:33 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 96A5A6DE1A34\r
+ for <notmuch@notmuchmail.org>; Mon,  6 Apr 2015 09:48:33 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id E347910019F;\r
+ Mon,  6 Apr 2015 19:48:09 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH] nmbug-status: add support for specifying sort order for\r
+ each view\r
+In-Reply-To: <20150406155659.GS10467@odin.tremily.us>\r
+References: <20150406155659.GS10467@odin.tremily.us>\r
+User-Agent: Notmuch/0.19+107~gab55bdb (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 06 Apr 2015 19:48:09 +0300\r
+Message-ID: <m2r3rx9p9y.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Apr 2015 16:48:37 -0000\r
+\r
+On Mon, Apr 06 2015, "W. Trevor King" <wking@tremily.us> wrote:\r
+\r
+> On Fri, Apr 03 2015, Jani Nikula <jani@nikula.org> wrote:\r
+>> Let each view have "sort" key with possible values "oldest-first",\r
+>> "newest-first", and "unsorted", and sort the results\r
+>> accordingly. Oldest first remains the default.\r
+>\r
+> I like it, but have a few suggestions to tweak the implementation.\r
+>\r
+>>      def _write_view(self, database, view, stream):\r
+>> +        sort = {\r
+>> +            'oldest-first': notmuch.Query.SORT.OLDEST_FIRST,\r
+>> +            'newest-first': notmuch.Query.SORT.NEWEST_FIRST,\r
+>> +            'unsorted': notmuch.Query.SORT.UNSORTED\r
+>> +        }\r
+>\r
+> I'd rather have this mapping defined in a global variable\r
+> (_SORT_TERMS?) or a class-wide attribute (Page.sort_terms?).\r
+> Alternatively, you could do something dynamic like:\r
+>\r
+>      sort_key = view.get('sort', 'oldest-first')\r
+>   sort_attribute = sort_key.upper().replace('-', '_'))\r
+>   try:\r
+>       sort = getattr(notmuch.Query.SORT, sort_attribute)\r
+>   except AttributeError:\r
+>       raise ConfigError('Invalid setting for {}: {!r}'.format(\r
+>           view['title'], sort_key))\r
+>\r
+> which would automatically keep the implementation in sync with the\r
+> available values in notmuch.Query.SORT.\r
+\r
+I like how this suggestion looks like.\r
+\r
+Tomi\r
+\r
+>\r
+>> -        q.set_sort(notmuch.Query.SORT.OLDEST_FIRST)\r
+>> +        if 'sort' in view and view['sort'] in sort:\r
+>> +            q.set_sort(sort[view['sort']])\r
+>> +        else:\r
+>> +            q.set_sort(notmuch.Query.SORT.OLDEST_FIRST)\r
+>\r
+> Instead of silently falling back to oldest-first if the requested\r
+> sort-key isn't available, I think we should be raising ConfigError so\r
+> the user knows they need to update their config.\r
+>\r
+> Cheers,\r
+> Trevor\r
+>\r
+> -- \r
+> This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
+> For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r