Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem

diff --git a/fc/42d3ea18821aee9d644bc9af396c81db5d1bd4 b/fc/42d3ea18821aee9d644bc9af396c81db5d1bd4
new file mode 100644 (file)
index 0000000..17fc8a7
--- /dev/null
+++ b/fc/42d3ea18821aee9d644bc9af396c81db5d1bd4
@@ -0,0 +1,90 @@
+Return-Path: <wiz@danbala.ifoer.tuwien.ac.at>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 60944431FC0\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 14:37:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5NR1jNTL64Cd for <notmuch@notmuchmail.org>;\r
+       Sat,  4 Jan 2014 14:37:48 -0800 (PST)\r
+Received: from danbala.ifoer.tuwien.ac.at (danbala.ifoer.tuwien.ac.at\r
+       [128.130.168.64])\r
+       by olra.theworths.org (Postfix) with ESMTP id 79742431FBD\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 14:37:48 -0800 (PST)\r
+Received: by danbala.ifoer.tuwien.ac.at (Postfix, from userid 116)\r
+       id E7E2D390DA4; Sat,  4 Jan 2014 23:37:42 +0100 (CET)\r
+Date: Sat, 4 Jan 2014 23:37:42 +0100\r
+From: Thomas Klausner <tk@giga.or.at>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: notmuch-0.16: realpath() compatibility issue; clang visibility\r
+       problem\r
+Message-ID: <20140104223742.GC16514@danbala.tuwien.ac.at>\r
+References: <20140103214735.GG27614@danbala.tuwien.ac.at>\r
+       <sfid-H20140104-145824-+018.98-1@spamfilter.osbf.lua>\r
+       <871u0nnaw8.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <871u0nnaw8.fsf@zancas.localnet>\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Jan 2014 22:37:59 -0000\r
+\r
+On Sat, Jan 04, 2014 at 09:18:15AM -0400, David Bremner wrote:\r
+> Thomas Klausner <tk@giga.or.at> writes:\r
+> \r
+> >                                 ^\r
+> > ./lib/notmuch-private.h:52:13: note: previous attribute is here\r
+> > #pragma GCC visibility push(hidden)\r
+> >             ^\r
+> \r
+> The clang related issues might be fixed in 0.17; can you try that (or\r
+> git master)?\r
+\r
+Yes, 0.17 fixed that problem.\r
+\r
+> >      size_t length;\r
+> > -    char *data, *filename;\r
+> > +    char *data, filename[MAXPATHLEN];\r
+> >      GError *error = NULL;\r
+> \r
+> I'm not sure what the right answer is here. MATHPATHLEN (and PATH_MAX)\r
+> are not necessarily defined; in particular this would break\r
+> compilation on GNU Hurd. Perhaps we should ship a compatibility\r
+> implementation of a POSIX.1-2008 compatible [1] realpath. Or maybe\r
+> realpath can be avoided completely here.\r
+\r
+A compatibility implementation for POSIX.1-2008-realpath would be\r
+great, as would be avoiding the call. Why is it necessary to resolve\r
+$HOME here?\r
+\r
+> > +      strcpy(filename, config->filename);\r
+> \r
+> Any reason not to use strncpy here?\r
+\r
+You're right, that'd be better here.\r
+\r
+> Of course bug reports and fixes in any form are always welcome, but even\r
+> more appreciated if they roughly follow [2]; mainly patches from git\r
+> with sensible commit messages, and some minor coding style issues.\r
+\r
+Thanks for the comments,\r
+ Thomas\r