--- /dev/null
+Return-Path: <patricktotzke@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id F0B9E6DE1873\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:03:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.01 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H2=-0.211, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id nZeFJloXLEOD for <notmuch@notmuchmail.org>;\r
+ Sun, 13 Mar 2016 05:03:23 -0700 (PDT)\r
+Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com\r
+ [209.85.217.176])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 047366DE186A\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:03:23 -0700 (PDT)\r
+Received: by mail-lb0-f176.google.com with SMTP id x1so206873965lbj.3\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:03:22 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=mime-version:reply-to:in-reply-to:references:date:message-id\r
+ :subject:from:to:cc;\r
+ bh=YCM6UPksz511AsnAT9ete9v5QFCnScKTahzFSsy6KRY=;\r
+ b=ht/Tx4uJK6C4JCbUdXUXqo9lT8544AegBT3dCTqZbwOlwd60xZwiCcKM8UmtMH1n2g\r
+ z6AM7BSaM4RpIRvdGjuDGLQllEA3x+2EMqX6s2qFK19D8itl5dce/TwFHAZtQvKCW/2y\r
+ n4Iqya4BK5n9OKzefraWeyPPA6hTSTWO+Bs8hWP00C+myIU9bgImTI+PYSTzJEtQalh5\r
+ WG78e9GDVJrsCJ09YF31OltEKwBvi1Dew9dA0R4OelN5g6t5GJgFege2MnzdVD05YZXf\r
+ JKwZa/FdZbWjYIo1jrfUpy4Yig34ws5d/+DtB/B3VeinM9zHQn7f61ytOmsgm8qAx5Fm\r
+ 312g==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:mime-version:reply-to:in-reply-to:references\r
+ :date:message-id:subject:from:to:cc;\r
+ bh=YCM6UPksz511AsnAT9ete9v5QFCnScKTahzFSsy6KRY=;\r
+ b=kZ1H9blGdTLudBQnkIwAlhSxXYJm0rinLhLTzv5KTvOWtzilbrxt35IjE7pOGeOCRw\r
+ AvTfNi8mCk/nZID981BMXMe9R4NfmWxBc/1A2N6YJnDWj77IegnavRlNaeCe66iFy1EH\r
+ YLFX4AOy3kbEJWl/BDDuj93N7vZA/tFm/AM06gKdxVfKL0FDRLhVnrlp5xOqcVc1R9X6\r
+ hDgkIpuKumfC2GHzmpqOfcwtUlU7gyqC2qZMJH79cz1YJxPgMq+mVZK0Rq/bIiAx17bP\r
+ nqCNuWH57MOgFxsE4fiFdyK895yvUTlUvkBrnjAJq6KoVdzdtQFIOAXcuddlh3rKJLKC\r
+ F3jQ==\r
+X-Gm-Message-State: AD7BkJJVg/+RENGuxmIszV18oqU4+HS5GZj9vD6lUTklsTBKp4UxcGOadEp8WHssCnjdQ72n9Z6SBN7IlAvmcQ==\r
+MIME-Version: 1.0\r
+X-Received: by 10.25.169.82 with SMTP id s79mr6432345lfe.47.1457870600694;\r
+ Sun, 13 Mar 2016 05:03:20 -0700 (PDT)\r
+Received: by 10.25.87.145 with HTTP; Sun, 13 Mar 2016 05:03:20 -0700 (PDT)\r
+Reply-To: patricktotzke@gmail.com\r
+In-Reply-To: <87oaaj64gh.fsf@zancas.localnet>\r
+References: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com>\r
+ <87r3ff64sa.fsf@zancas.localnet> <87oaaj64gh.fsf@zancas.localnet>\r
+Date: Sun, 13 Mar 2016 12:03:20 +0000\r
+Message-ID:\r
+ <CAM7JpKkXciAooWMaQ+uuWxTAs_O6DAr0-u-n+uTy2c1w-tkm3g@mail.gmail.com>\r
+Subject: Re: [PATCH] use notmuch_database_open_verbose\r
+From: Patrick Totzke <patricktotzke@gmail.com>\r
+To: David Bremner <david@tethera.net>\r
+Cc: "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>\r
+Content-Type: multipart/alternative; boundary=001a114106d848727c052decf368\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Mar 2016 12:03:26 -0000\r
+\r
+--001a114106d848727c052decf368\r
+Content-Type: text/plain; charset=UTF-8\r
+\r
+As far as I understand the bindings, the returned message is not needed\r
+because the return\r
+value of `Database._open` (line 212) contains information about the type of\r
+error that occurred.\r
+This is passed on two lines below if the open-call was unsuccessful.\r
+\r
+The docstrings for this method are not ideal (the mentioned "status"\r
+parameter is actually called "mode") but in terms of functionality it seems\r
+ok.\r
+\r
+On 12 March 2016 at 16:33, David Bremner <david@tethera.net> wrote:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+> >> - """notmuch_database_open"""\r
+> >> - _open = nmlib.notmuch_database_open\r
+> >> + """notmuch_database_open_verbose"""\r
+> >> + _open = nmlib.notmuch_database_open_verbose\r
+> >> _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)]\r
+> >> _open.restype = c_uint\r
+> >\r
+> > I expect you probably want to add the new binding, rather than replacing\r
+> > the old one. Otherwise updating the bindings will break all bindings\r
+> > using scripts.\r
+>\r
+> Oh silly me. That's not actually exposed to the python API, so that's\r
+> fine. On the other hand, don't you want to update the argument types and\r
+> do something useful (throw an exception?) with the returned message? As\r
+> it stands you lose information.\r
+>\r
+> d\r
+>\r
+\r
+--001a114106d848727c052decf368\r
+Content-Type: text/html; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+<div dir=3D"ltr"><div><div><div>As far as I understand the bindings, the re=\r
+turned message is not needed because the return<br></div>value of `Database=\r
+._open` (line 212) contains information about the type of error that occurr=\r
+ed.<br></div>This is passed on two lines below if the open-call was unsucce=\r
+ssful.<br><br></div>The\r
+ docstrings for this method are not ideal (the mentioned "status"=\r
+=20\r
+parameter is actually called "mode") but in terms of functionalit=\r
+y it=20\r
+seems ok.</div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On=\r
+ 12 March 2016 at 16:33, David Bremner <span dir=3D"ltr"><<a href=3D"mai=\r
+lto:david@tethera.net" target=3D"_blank">david@tethera.net</a>></span> w=\r
+rote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=\r
+r-left:1px #ccc solid;padding-left:1ex"><span class=3D"">David Bremner <=\r
+<a href=3D"mailto:david@tethera.net">david@tethera.net</a>> writes:<br>\r
+<br>\r
+>> -=C2=A0 =C2=A0 """notmuch_database_open""=\r
+"<br>\r
+>> -=C2=A0 =C2=A0 _open =3D nmlib.notmuch_database_open<br>\r
+>> +=C2=A0 =C2=A0 """notmuch_database_open_verbose&quo=\r
+t;""<br>\r
+>> +=C2=A0 =C2=A0 _open =3D nmlib.notmuch_database_open_verbose<br>\r
+>>=C2=A0 =C2=A0 =C2=A0 _open.argtypes =3D [c_char_p, c_uint, POINTER(=\r
+NotmuchDatabaseP)]<br>\r
+>>=C2=A0 =C2=A0 =C2=A0 _open.restype =3D c_uint<br>\r
+><br>\r
+> I expect you probably want to add the new binding, rather than replaci=\r
+ng<br>\r
+> the old one. Otherwise updating the bindings will break all bindings<b=\r
+r>\r
+> using scripts.<br>\r
+<br>\r
+</span>Oh silly me. That's not actually exposed to the python API, so t=\r
+hat's<br>\r
+fine. On the other hand, don't you want to update the argument types an=\r
+d<br>\r
+do something useful (throw an exception?) with the returned message?=C2=A0 =\r
+As<br>\r
+it stands you lose information.<br>\r
+<span class=3D"HOEnZb"><font color=3D"#888888"><br>\r
+d<br>\r
+</font></span></blockquote></div><br></div>\r
+\r
+--001a114106d848727c052decf368--\r
projects / notmuch-archives.git / commitdiff