Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller

diff --git a/d1/a86886e16890c8604eb76af655fa149092ad33 b/d1/a86886e16890c8604eb76af655fa149092ad33
new file mode 100644 (file)
index 0000000..e8fa24d
--- /dev/null
+++ b/d1/a86886e16890c8604eb76af655fa149092ad33
@@ -0,0 +1,85 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1E607429E4F\r
+       for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 05:01:50 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id eZVMEhBklc5G for <notmuch@notmuchmail.org>;\r
+       Tue,  5 Nov 2013 05:01:42 -0800 (PST)\r
+Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com\r
+ [74.125.82.42])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 60656429E45   for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 05:01:42 -0800\r
+ (PST)\r
+Received: by mail-wg0-f42.google.com with SMTP id n12so2973811wgh.5\r
+       for <notmuch@notmuchmail.org>; Tue, 05 Nov 2013 05:01:40 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:cc:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=c40WBy0qJUCJgWzCWwkl6XGaeJSO1htEbbAx0/qSLZw=;\r
+       b=Ov8VAoAkKhVzyDMb7kmjZIT677eqThpZ11Ms/LLn33dTln6K5gpiIzsLDc4F9pmHQ8\r
+       Poc1CJDSWQrFQEH6tQboeFH1sdIoBXQNmujNBBIWF+ss/SyRyUeCO7/sbSCzXtESFx+w\r
+       xQ2GoYR2o4cvSWNaTiAXUzVzd6N7sQuC/5vLQD5EY0dzEnNoG7fEHZJKu2XE9q+Q8lrS\r
+       oTgRiWYotBzP9k5kk0L3Do7hiL3tX0XHPtQm+CXIk82gvzh0rFpIShHMD9rBltGzk9Qi\r
+       ZYdhwgZ0heaphcIWcHmCzIA2FiBXYdajbCyusgoi7e75iSBxjei4WlZWz+qH7rLI322E\r
+       W2uQ==\r
+X-Gm-Message-State:\r
+ ALoCoQnkggH5Y/43K9In1Oh65fxIFlOHZwfl98kYlRlY1n/dHbqmr9DbDju3RwR9dgCj/GEM5gyV\r
+X-Received: by 10.180.160.165 with SMTP id xl5mr15989336wib.48.1383650137413; \r
+       Tue, 05 Nov 2013 03:15:37 -0800 (PST)\r
+Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
+       by mx.google.com with ESMTPSA id fu1sm13567130wib.8.2013.11.05.03.15.34\r
+       for <multiple recipients>\r
+       (version=TLSv1.1 cipher=RC4-SHA bits=128/128);\r
+       Tue, 05 Nov 2013 03:15:36 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 07/11] lib: use the compaction backup path provided by\r
+       the caller\r
+In-Reply-To: <87ob5zqft7.fsf@zancas.localnet>\r
+References: <cover.1383481295.git.jani@nikula.org>\r
+       <6e8053834c8ab856c2ebab881069f18b2badcf71.1383481295.git.jani@nikula.org>\r
+       <87ob5zqft7.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.16+115~gd647c65 (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 05 Nov 2013 12:15:19 +0100\r
+Message-ID: <87sivb9k1k.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Nov 2013 13:01:50 -0000\r
+\r
+On Tue, 05 Nov 2013, David Bremner <david@tethera.net> wrote:\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> +    backup_path = talloc_asprintf (config, "%s/xapian.old", path);\r
+>> +    if (! backup_path)\r
+>> +   return 1;\r
+>> +\r
+>\r
+> Is it intentional that no message is printed here? A random glance at\r
+> notmuch-search.c suggests we usually print a message on OOM in the CLI.\r
+\r
+Oversight.\r
+\r
+Jani.\r