Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'

diff --git a/dc/30b3dfad9612f5ecd28dd2ff76a6eeff3c124b b/dc/30b3dfad9612f5ecd28dd2ff76a6eeff3c124b
new file mode 100644 (file)
index 0000000..37b5502
--- /dev/null
+++ b/dc/30b3dfad9612f5ecd28dd2ff76a6eeff3c124b
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 05DB76DE0231\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 00:17:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.645\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.645 tagged_above=-999 required=5 tests=[AWL=-0.007,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id SMagaZ6eu1Q2 for <notmuch@notmuchmail.org>;\r
+ Wed, 10 Feb 2016 00:17:13 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 819616DE021E\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 00:17:13 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 0991910007F;\r
+ Wed, 10 Feb 2016 10:17:30 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'\r
+In-Reply-To: <87wpqd61ez.fsf@qmul.ac.uk>\r
+References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com>\r
+ <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>\r
+ <m2io1x4oop.fsf@dme.org> <87wpqd61ez.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 10 Feb 2016 10:17:29 +0200\r
+Message-ID: <m21t8lnfmu.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 10 Feb 2016 08:17:16 -0000\r
+\r
+On Tue, Feb 09 2016, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> On Tue, 09 Feb 2016, David Edmondson <dme@dme.org> wrote:\r
+>> On Sat, Jun 13 2015, Mark Walters wrote:\r
+>>> Change the key binding for filter (or "limit") in search-mode. This\r
+>>> gives consistency with the new filter in show-mode, and frees 'f' for\r
+>>> forward-thread in the future.\r
+>>\r
+>> Is there a conclusion on this change? The patch itself seems obviously\r
+>> fine from a code perspective, at issue is more whether it's acceptable\r
+>> to change the key binding.\r
+>>\r
+>> The equivalent binding in notmuch-show mode is already "l", and I think\r
+>> that it makes sense to be consistent (i.e. the change should be\r
+>> applied).\r
+>\r
+> I broadly agree, particularly as it will free up f for forwarding a\r
+> thread in search view (which is easy to do on top of\r
+> id:1454931262-21362-1-git-send-email-dme@dme.org).\r
+>\r
+> It will be annoying in the short term to learn the change, but I don't\r
+> see a way round that.\r
+\r
+In short, +1 for the change.\r
+\r
+Tomi\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>>> ---\r
+>>>  emacs/notmuch.el | 4 ++--\r
+>>>  1 file changed, 2 insertions(+), 2 deletions(-)\r
+>>>\r
+>>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+>>> index 6564816..06e3b94 100644\r
+>>> --- a/emacs/notmuch.el\r
+>>> +++ b/emacs/notmuch.el\r
+>>> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map\r
+>>>      (define-key map "o" 'notmuch-search-toggle-order)\r
+>>>      (define-key map "c" 'notmuch-search-stash-map)\r
+>>>      (define-key map "t" 'notmuch-search-filter-by-tag)\r
+>>> -    (define-key map "f" 'notmuch-search-filter)\r
+>>> +    (define-key map "l" 'notmuch-search-filter)\r
+>>>      (define-key map [mouse-1] 'notmuch-search-show-thread)\r
+>>>      (define-key map "*" 'notmuch-search-tag-all)\r
+>>>      (define-key map "a" 'notmuch-search-archive-thread)\r
+>>> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order ()\r
+>>>    (notmuch-search-refresh-view))\r
+>>>  \r
+>>>  (defun notmuch-search-filter (query)\r
+>>> -  "Filter the current search results based on an additional query string.\r
+>>> +  "Filter or LIMIT the current search results based on an additional query string.\r
+>>>  \r
+>>>  Runs a new search matching only messages that match both the\r
+>>>  current search results AND the additional query string provided."\r
+>>> -- \r
+>>> 2.1.4\r