Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch address results

diff --git a/cc/fb2c7e09fb0a6639e076199061557b04116f18 b/cc/fb2c7e09fb0a6639e076199061557b04116f18
new file mode 100644 (file)
index 0000000..991aa6e
--- /dev/null
+++ b/cc/fb2c7e09fb0a6639e076199061557b04116f18
@@ -0,0 +1,93 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 9F8F96DE00CB\r
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 00:33:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.035\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.035 tagged_above=-999 required=5\r
+ tests=[AWL=-0.059, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01,\r
+ RCVD_IN_MSPIKE_WL=-0.01, URIBL_SBL=0.644, URIBL_SBL_A=0.1]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 37le4-320Mhi for <notmuch@notmuchmail.org>;\r
+ Sun, 30 Aug 2015 00:33:08 -0700 (PDT)\r
+Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com\r
+ [209.85.212.171])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 6736A6DE005F\r
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 00:33:08 -0700 (PDT)\r
+Received: by wizs10 with SMTP id s10so2443539wiz.1\r
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 00:33:06 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type;\r
+ bh=tMyqtdCrrFb2wQI/8fZ297PQxDca9Fl49vkXhhIQwf4=;\r
+ b=IBOL25QnvN9iei+jChGFVdVOrUSYyF7y6jh4pGTTOl0d/3/LTzHU5a3brY7ILL5xS/\r
+ /m93obcsvzL6k46X+uTqMTAMTrNZUAMniGyPUN/59uIGpkht8NXqymrlsUr7OHnDe3CW\r
+ HB2rU57xNxcptGyf5yce/etPU+4BevjkNZ//bbHaaz0u1Z00C+AahTdJZk3D0WYnJPGT\r
+ sLN0VfhhXRPpvPGonBoVA5/dAovNaXXic7paHL7hCbGjRO0CsWeuUxJ45tyh19Z+CNH6\r
+ q0bfDWzGwkN6MXgkEhf1KYDMJtmHptsEYLHnTsrGaRDqc0qxoVgXRjhZ4qudS5cmHEgs\r
+ Ha7g==\r
+X-Gm-Message-State:\r
+ ALoCoQkFmyG8VD4DoBP2GZxdaDa8FancyR7vXgLUZhY5KwNPv/bKXbNwh/hoaiZYai48KjlGV0uV\r
+X-Received: by 10.194.122.200 with SMTP id lu8mr19114548wjb.83.1440919985829; \r
+ Sun, 30 Aug 2015 00:33:05 -0700 (PDT)\r
+Received: from localhost (mobile-access-bcee4f-131.dhcp.inet.fi.\r
+ [188.238.79.131])\r
+ by smtp.gmail.com with ESMTPSA id j2sm16173181wjq.5.2015.08.30.00.33.04\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Sun, 30 Aug 2015 00:33:05 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch\r
+ address results\r
+In-Reply-To: <87d1y5tvg5.fsf@maritornes.cs.unb.ca>\r
+References: <cover.1440859765.git.jani@nikula.org>\r
+ <5badd1d1d46690987558dd2283efdc69be4c8c99.1440859765.git.jani@nikula.org>\r
+ <87d1y5tvg5.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.20.2+66~gb33abd9 (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 30 Aug 2015 10:33:04 +0300\r
+Message-ID: <87k2sd1b9r.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Aug 2015 07:33:10 -0000\r
+\r
+On Sun, 30 Aug 2015, David Bremner <david@tethera.net> wrote:\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>\r
+>> +   { NOTMUCH_OPT_KEYWORD, &ctx->dupe, "deduplicate", 'x',\r
+>\r
+> probably you want 'D' or 'd' here. Not that it makes a practical\r
+> difference at this point.\r
+>\r
+>> +     (notmuch_keyword_t []){ { "yes", -1 },\r
+>\r
+> I'm not very enthusiastic about reusing ctx->dupe for this.\r
+> In particular the use of -1 for yes is off-putting\r
+> It seems better to allocate another word of memory and use an\r
+> enum, as elsewhere.\r
+\r
+Agreed on both.\r
+\r
+BR,\r
+Jani.\r
+\r