--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 176E1431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 8 Dec 2012 01:29:03 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 9G8RA9odOKv3 for <notmuch@notmuchmail.org>;\r
+ Sat, 8 Dec 2012 01:29:02 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 6FBD5431FAE\r
+ for <notmuch@notmuchmail.org>; Sat, 8 Dec 2012 01:29:02 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1ThGiQ-0001OI-1i; Sat, 08 Dec 2012 09:28:58 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1ThGiP-0004oA-OS; Sat, 08 Dec 2012 09:28:57 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/10] CLI output versioning\r
+In-Reply-To: <87pq2sx86o.fsf@awakening.csail.mit.edu>\r
+References: <1354416002-3557-1-git-send-email-amdragon@mit.edu>\r
+ <87pq2sx86o.fsf@awakening.csail.mit.edu>\r
+User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 08 Dec 2012 09:29:02 +0000\r
+Message-ID: <878v98hoyp.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: eb4857d49b031bd1c3ca44b88d174820 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 08 Dec 2012 09:29:03 -0000\r
+\r
+\r
+Hi\r
+\r
+Overall this series looks good. As we discussed on irc I think i would\r
+prefer global NOTMUCH_SCHEMA_MIN as I am a little worried about these\r
+proliferating (eg if someone decides text output also needs versioning\r
+etc) In addition, if we do find the distinction useful it would be easy\r
+to add at a later date.\r
+\r
+One tiny comment on the manpage updates: now that you mention two return\r
+values explicitly should the other possibilities be mentioned too or are\r
+they so obvious it is not needed?\r
+\r
+Would it be worth having some emacs test for the error handling? (eg set\r
+notmuch-command to something giving some stderr and an error) Inherently\r
+these code paths won't be tested much so I think tests could be\r
+particularly useful.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+\r
+\r
+On Mon, 03 Dec 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> (Sorry; I forgot to include a cover letter.)\r
+>\r
+> This series is intended to help with our long-standing output format\r
+> versioning issue. While the JSON format is amenable to extension,\r
+> there's still a high barrier to extensions because of the need to\r
+> support them going forward, and an even higher barrier to modifications\r
+> that break backwards compatibility. Versioning will make the format\r
+> more dynamic, enabling us to easily improve and iterate on it. It will\r
+> also address the slew of confusing bugs that people encounter when they\r
+> use a mismatched CLI and front-end.\r
+>\r
+> On IRC we've talking about adding version information to the output\r
+> format itself. This series takes a different and, I think, better\r
+> approach: callers request a specific output format version on the\r
+> command line. This allows notmuch to remain backwards compatible with\r
+> older format versions when it's easy or necessary. This also doesn't\r
+> require shoehorning a version number into the output, which would be\r
+> awkward for both the CLI and the consumer.\r
+>\r
+> I called the argument --use-schema, but I'm open to other suggestions.\r
+> --use-schema is technically accurate, but perhaps not as self-describing\r
+> as something like --schema-version or --format-version (to parallel\r
+> --format).\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff