Re: [PATCH v2] Use the Xapian::DB_RETRY_LOCK flag when available

diff --git a/82/da1f9663bb7d0afd67493c12e2ed3a354c63bf b/82/da1f9663bb7d0afd67493c12e2ed3a354c63bf
new file mode 100644 (file)
index 0000000..1913378
--- /dev/null
+++ b/82/da1f9663bb7d0afd67493c12e2ed3a354c63bf
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id D30186DE00F5\r
+ for <notmuch@notmuchmail.org>; Thu,  5 May 2016 03:33:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.013\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.013 tagged_above=-999 required=5\r
+ tests=[AWL=-0.002, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id NM8ES-NVB_J8 for <notmuch@notmuchmail.org>;\r
+ Thu,  5 May 2016 03:33:32 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 3E23E6DE00DF\r
+ for <notmuch@notmuchmail.org>; Thu,  5 May 2016 03:33:32 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ayGav-0007Il-Qe; Thu, 05 May 2016 06:33:21 -0400\r
+Received: (nullmailer pid 3363 invoked by uid 1000);\r
+ Thu, 05 May 2016 10:33:25 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Istvan Marko <notmuch@kismala.com>, Jani Nikula <jani@nikula.org>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] Use the Xapian::DB_RETRY_LOCK flag when available\r
+In-Reply-To: <m3wpnb0xc6.fsf@zsu.kismala.com>\r
+References: <m38tzr2n6v.fsf@zsu.kismala.com> <87k2jbgl2b.fsf@nikula.org>\r
+ <m3wpnb0xc6.fsf@zsu.kismala.com>\r
+User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 05 May 2016 07:33:25 -0300\r
+Message-ID: <87futw6bgq.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 05 May 2016 10:33:41 -0000\r
+\r
+Istvan Marko <notmuch@kismala.com> writes:\r
+\r
+> Regarding tests, I couldn't think of a meaningful test for this. We get\r
+> different behaviors depending on the Xapian version and if we try do\r
+> some kind of a concurrent locking test we'd really be just testing\r
+> Xapian's locking code rather than notmuch.\r
+\r
+We would be testing the build/configuration part to make sure we are\r
+enabling the right flags, but more importantly testing the error\r
+handling code, since we have to catch exceptions and pass them back\r
+through the C library interface as error codes. One thing that would\r
+make this easier to test is adding some finer grain errors than\r
+"NOTMUCH_STATUS_XAPIAN_EXCEPTION" for notmuch_database_open_verbose to\r
+return, to distinguish between the case of immediate failure and\r
+timeout.  Although it's not clear to me that Xapian actually provides a\r
+timeout when DB_RETRY_LOCK is used.\r