Re: [Patch v3] util: add gzreadline
authorDavid Bremner <david@tethera.net>
Sun, 30 Mar 2014 14:37:03 +0000 (11:37 +2100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:01:05 +0000 (10:01 -0800)
46/6d99b42c04c9d77d4311b5367e15ddbe7c8059 [new file with mode: 0644]

diff --git a/46/6d99b42c04c9d77d4311b5367e15ddbe7c8059 b/46/6d99b42c04c9d77d4311b5367e15ddbe7c8059
new file mode 100644 (file)
index 0000000..ff2c995
--- /dev/null
@@ -0,0 +1,73 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D7D7E431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 07:37:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Cc0U7mgkv81I for <notmuch@notmuchmail.org>;\r
+       Sun, 30 Mar 2014 07:37:13 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 67810431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 07:37:13 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WUGrD-0003YJ-GJ; Sun, 30 Mar 2014 11:37:07 -0300\r
+Received: (nullmailer pid 22462 invoked by uid 1000); Sun, 30 Mar 2014\r
+       14:37:03 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v3] util: add gzreadline\r
+In-Reply-To: <m2txafvori.fsf@guru.guru-group.fi>\r
+References: <m2zjk8um02.fsf@guru.guru-group.fi>\r
+       <1396178602-7583-1-git-send-email-david@tethera.net>\r
+       <m2txafvori.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.17+164~g31fc76b (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 30 Mar 2014 11:37:03 -0300\r
+Message-ID: <877g7beos0.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Mar 2014 14:37:19 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> "On error, gzgets() shall return Z_NULL.\r
+>\r
+> In light of this I'd say no. can we set out-of-memory using some public\r
+> api so it is available using gzerror()\r
+>\r
+>\r
+\r
+Since we already "broke" the API, what about\r
+\r
+1) start a "util_status_t" enum, later unify that with the hex_ return codes.\r
+\r
+2) \r
+\r
+util_status_t\r
+gz_getline (void *ctx, char **buf, size_t *bufsize, ssize_t *bytes_read,\r
+           gzFile stream);\r
+\r
+d\r