Re: [PATCH v2 0/5] New output format sexp (Lisp S-Expressions)

diff --git a/b9/a254a5f88aa60fd79b3d00dc4535bf2df71d71 b/b9/a254a5f88aa60fd79b3d00dc4535bf2df71d71
new file mode 100644 (file)
index 0000000..c915cdd
--- /dev/null
+++ b/b9/a254a5f88aa60fd79b3d00dc4535bf2df71d71
@@ -0,0 +1,127 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7C170431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Dec 2012 09:07:58 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Y43z74OHqf+N for <notmuch@notmuchmail.org>;\r
+       Tue,  4 Dec 2012 09:07:54 -0800 (PST)\r
+Received: from mail-la0-f53.google.com (mail-la0-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3C076431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Dec 2012 09:07:54 -0800 (PST)\r
+Received: by mail-la0-f53.google.com with SMTP id w12so3572120lag.26\r
+       for <notmuch@notmuchmail.org>; Tue, 04 Dec 2012 09:07:52 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type:x-gm-message-state;\r
+       bh=44fUyli5oPeB2mTyDhZCSircK2AGRbDBM0Z85iCRyaI=;\r
+       b=elREwdkk31y5oqSClhUI1uKRvn86Iu2dkAlyBfhSk1+hDuIM+bu+zZVIhkG4kg8I7A\r
+       MYlmZ9vUxqrhynM92Uu39uVmqyijoKoWx9+NP4XOYB/nG721WsOpTL0qUipXGapj3PFc\r
+       2Pv61aLW+RK0FTi4AKCYsqwwkAwaQrfDkZI+892x2pa+PecfDHGjQDPz6Y3zxYga3nzL\r
+       3GJf8DksvU3HZwBh03tQxd85Xue8vDl8pLQNLLkr5Btn84GjuxDso5EkM+oGm0pOzNGo\r
+       N+dNaOOwesFcGUXZxqUdhrhrgoozEAvXKzr2gffHj5QKzc18frDUj58L/Rhlqx2CVdVq\r
+       hOfQ==\r
+Received: by 10.152.144.10 with SMTP id si10mr13623174lab.55.1354640872324;\r
+       Tue, 04 Dec 2012 09:07:52 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.\r
+       [80.223.81.27])\r
+       by mx.google.com with ESMTPS id pw17sm976447lab.5.2012.12.04.09.07.47\r
+       (version=SSLv3 cipher=OTHER); Tue, 04 Dec 2012 09:07:49 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Peter Feigl <craven@gmx.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/5] New output format sexp (Lisp S-Expressions)\r
+In-Reply-To: <1354632382-15609-1-git-send-email-craven@gmx.net>\r
+References: <1354264143-30173-1-git-send-email-craven@gmx.net>\r
+       <1354632382-15609-1-git-send-email-craven@gmx.net>\r
+User-Agent: Notmuch/0.14+137~g9203c35 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i686-pc-linux-gnu)\r
+Date: Tue, 04 Dec 2012 19:07:46 +0200\r
+Message-ID: <87boe9lp99.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQk0ZWefhJrj2fR85I7MfObeMixCWihiyysk8Ete6TWXD7wcrszqd5xX2NCrFXSNgC+3egrg\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Dec 2012 17:07:58 -0000\r
+\r
+\r
+Hi Peter -\r
+\r
+On Tue, 04 Dec 2012, Peter Feigl <craven@gmx.net> wrote:\r
+> This patch series adds a new output format "sexp" to notmuch-reply,\r
+> notmuch-show and notmuch-search. These are useful for the Android mobile\r
+> client and perhaps other Lisp programs as well.\r
+> After the switch to a generic structured output printer, which was\r
+> committed some months ago, these patches just add another one (like the\r
+> json structured output printer).\r
+> Basic tests and updates to the man pages are also included.\r
+>\r
+>\r
+> Peter Feigl (5):\r
+>   Adding an S-expression structured output printer.\r
+>   Rename the -json printer functions in notmuch-reply and    \r
+>     notmuch-show to generic -sprinter functions.\r
+>   Use the S-Expression structured printer in notmuch-show,\r
+>     notmuch-reply     and notmuch-search.\r
+\r
+Patches 1-3 look good.\r
+\r
+>   Adding tests for --format=sexp.\r
+\r
+Did not review.\r
+\r
+>   Updating man pages for new S-Expression output format.\r
+\r
+Did not review, but noticed it adds lines with trailing whitespace.\r
+\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+>\r
+>  Makefile.local            |   1 +\r
+>  man/man1/notmuch-reply.1  |  14 ++-\r
+>  man/man1/notmuch-search.1 |  15 +--\r
+>  man/man1/notmuch-show.1   |  36 +++++--\r
+>  notmuch-client.h          |   8 +-\r
+>  notmuch-reply.c           |  43 ++++----\r
+>  notmuch-search.c          |   6 +-\r
+>  notmuch-show.c            |  48 +++++----\r
+>  sprinter-sexp.c           | 250 ++++++++++++++++++++++++++++++++++++++++++++++\r
+>  sprinter.h                |   4 +\r
+>  test/notmuch-test         |   1 +\r
+>  test/sexp                 |  48 +++++++++\r
+>  12 files changed, 414 insertions(+), 60 deletions(-)\r
+>  create mode 100644 sprinter-sexp.c\r
+>  create mode 100755 test/sexp\r
+>\r
+> -- \r
+> 1.8.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r