Re: [PATCH v4 0/6] Config-related patches

diff --git a/85/28af7ac1a24ea5359b902396bb1e420de40155 b/85/28af7ac1a24ea5359b902396bb1e420de40155
new file mode 100644 (file)
index 0000000..16f94f0
--- /dev/null
+++ b/85/28af7ac1a24ea5359b902396bb1e420de40155
@@ -0,0 +1,99 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 162A7431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Apr 2012 12:33:09 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id mYY0ul5Yp-az for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Apr 2012 12:33:08 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id A363F431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Apr 2012 12:33:08 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 4F1EF66E0142;\r
+       Sat, 14 Apr 2012 12:33:08 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (unknown [76.89.193.65])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 8D01766E012F;\r
+       Sat, 14 Apr 2012 12:33:04 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 45A5845D; Sat, 14 Apr 2012 12:33:04 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, Peter Wang <novalazy@gmail.com>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 0/6] Config-related patches\r
+In-Reply-To: <87zkaelnxr.fsf@qmul.ac.uk>\r
+References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>\r
+       <1334367666-10954-1-git-send-email-novalazy@gmail.com>\r
+       <87zkaelnxr.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.12+112~gffb05d6 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 14 Apr 2012 12:33:03 -0700\r
+Message-ID: <87sjg6yuq8.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Apr 2012 19:33:09 -0000\r
+\r
+--=-=-=\r
+\r
+On Sat, Apr 14 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Two minor comments which you might like to consider (but definitely are\r
+> not required):\r
+>     1) You could check that there are no further arguments when the user\r
+>     calls `notmuch config list'\r
+\r
+This doesn't seem so necessary to me.  I'm fine if it just silently\r
+ignores extra arguments.\r
+\r
+>     2) In the man page you could explicitly say what the output is for a\r
+>     configuration item which has not been set.\r
+\r
+I'm also fine with it as it is.  I think it's implied that if the value\r
+is null then the field is left blank.  That's ok.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPidDwAAoJEO00zqvie6q8Kf8QAKMPXert7BUs163SEDKnfUu/\r
+tw9wRYDtEodRHRuS2g7P9MxcV25JjbOiQ9JiUjv2dRMW9R9O0O7iQUNZMEO03O9z\r
+n1wv9qeSfUarhIh6d99dtPtb/l8jZVt7QO9RYeIujOh/YFd7CIhTDiZdjm5b13R6\r
+6frw1mHtyTizzq4QIJOr4sD5jXU78ojQjFNTmv35lvzJ4zBsgORAcCk1T+YfHPYc\r
+2DcPeR2PhuYPBixiw2c6yAadY6c5a+hAvOEX0Gh+FcV0K/0cY63vIDjR9Zaf7Uz+\r
+xVZbF2pJyDrhNR+HuaFMOJQx0kcGUB2HeNgQU0it6zbBc6EIArhnflTE+hWLkd1g\r
+xgMBFenUWpu8BShAJ7DH6LKxealQram2xMnyIOrJ0hnq7acqUdPsSzHTJhxmE2YG\r
+c/sVJhr/clNNP0vpoV+nwkLbRI2Xj3wWCBPCNv4x//AwFxIYMbMdSqLOU1WdKhFW\r
+LEWFGESIGjHvPIVcM+sFCOJyyEZT9cpStMeaDGWXLOtFGBNt5uWXDhrikr0mPdPF\r
+nHCVByVUzV47pTv78SrKGqTiKodkaU14e0hNRJh+ZfdSs2M/E1TYGVElRVWrhGvP\r
+xPH++Nt59WK+cQpTnKq4AU9PWCMa+fpLacQu3JVRwLhHttOImhtzNRT6ApIQDPc+\r
+RjHetQG9ZumSgE4NlRYU\r
+=11cv\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r