Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

diff --git a/d7/33ee8a9609616d4f5fa554ddbc8b6818a58838 b/d7/33ee8a9609616d4f5fa554ddbc8b6818a58838
new file mode 100644 (file)
index 0000000..e870009
--- /dev/null
+++ b/d7/33ee8a9609616d4f5fa554ddbc8b6818a58838
@@ -0,0 +1,104 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2248B431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 16:55:08 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.7\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.7 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ptsuceMBzqVb for <notmuch@notmuchmail.org>;\r
+       Fri, 21 Jun 2013 16:54:56 -0700 (PDT)\r
+Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com\r
+       [209.85.220.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 446A0431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 16:54:56 -0700 (PDT)\r
+Received: by mail-pa0-f48.google.com with SMTP id kp12so8498515pab.35\r
+       for <notmuch@notmuchmail.org>; Fri, 21 Jun 2013 16:54:54 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:message-id:from:to:cc:subject:in-reply-to:references\r
+       :mime-version:content-type:content-disposition\r
+       :content-transfer-encoding;\r
+       bh=AMjHWA/tXig6YRL74n86iS+0XyPbPIiKffv9xWxME74=;\r
+       b=Bfanhjoc2UlxaNoBm812I67oNQzkZ1GU4KKYkT9c105MeDniRt7ErDNDGPwYf9HZR0\r
+       kSIicNxPbfPMrccoft4T0aVxhWfPpgRCzpbAjeANGXIaMOZfHJnclZ5OpxzREHbZ+NH6\r
+       RVsP3AdJY80mRH9W0kvpzvBBSdgzuRiFDAqGcXcOdI8UEQAad/UoI8KE8vj+cHPbi3Rf\r
+       Ygr0qP6P/J2RIbNQ5B78AnG8e59Jw1TaqBH9EcN3BmG/axSJckm/4Pg3ADSmrAda7iTy\r
+       nkLcmq0rbFLzK8qcELH2qW2gEGLxD1akk/i/gdKMx29xzvy56+sWr64HobougIt2i7L3\r
+       Jc1A==\r
+X-Received: by 10.68.223.34 with SMTP id qr2mr6770083pbc.75.1371858894395;\r
+       Fri, 21 Jun 2013 16:54:54 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPSA id ri8sm6753646pbc.3.2013.06.21.16.54.51\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Fri, 21 Jun 2013 16:54:53 -0700 (PDT)\r
+Date: Sat, 22 Jun 2013 09:55:36 +1000\r
+Message-ID: <20130622095536.GA1996@hili.localdomain>\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t\r
+In-Reply-To: <m2txkrk9ua.fsf@guru.guru-group.fi>\r
+References: <1368301809-12532-1-git-send-email-markwalters1009@gmail.com>\r
+       <1368301809-12532-8-git-send-email-markwalters1009@gmail.com>\r
+       <87bo8edif8.fsf@qmul.ac.uk> <87fvwdx19x.fsf@qmul.ac.uk>\r
+       <m2txkrk9ua.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: 8bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 21 Jun 2013 23:55:08 -0000\r
+\r
+On Fri, 21 Jun 2013 13:59:57 +0300, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Thu, Jun 20 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> \r
+> > I think we should decide before 0.16 whether to go with this patch and\r
+> > patch 8/8 or for Peter's suggestion at\r
+> > id:1368454815-1854-1-git-send-email-novalazy@gmail.com\r
+> >\r
+> > Now we have an enum for the NOTMUCH_EXCLUDE possibilities (rather than a\r
+> > bool) I think it makes sense to implement NOTMUCH_EXCLUDE_FALSE properly\r
+> > but I am happy with either choice.\r
+> \r
+> So, the choice here is to choose between\r
+> \r
+> id:"1368454815-1854-1-git-send-email-novalazy@gmail.com"\r
+> and\r
+> id:"87bo8edif8.fsf@qmul.ac.uk" \r
+> \r
+> (might be hard to catch from this thread -- was easier to take from\r
+> http://nmbug.tethera.net/status/ )\r
+> \r
+> Both apply cleanly to current master ( d0bd88f )\r
+> \r
+> While Peter's version surely looks simpler (and may work, didn't test atm)\r
+> the comments Mark presents makes sense (especially the "subtlety" thing ;)\r
+> \r
+> IMHO Mark's version makes future development "safer" and therefore my\r
+> vote (or million of those) goes to id:"87bo8edif8.fsf@qmul.ac.uk"\r
+\r
+Sure, I don't care.\r
+\r
+Peter\r