--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 332D4431FBC\r
+ for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:20:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id aM4Sl5pbkAN8 for <notmuch@notmuchmail.org>;\r
+ Tue, 22 Oct 2013 17:19:57 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu\r
+ [18.7.68.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id A9758431FAE\r
+ for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 17:19:57 -0700 (PDT)\r
+X-AuditID: 12074422-b7f5a8e000000a34-77-5267162cd29d\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id DF.B5.02612.C2617625; Tue, 22 Oct 2013 20:19:56 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r9N0JtIp013499; \r
+ Tue, 22 Oct 2013 20:19:56 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9N0Jri0005132\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Tue, 22 Oct 2013 20:19:54 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1VYmAy-0000oG-SP; Tue, 22 Oct 2013 20:19:52 -0400\r
+Date: Tue, 22 Oct 2013 20:19:52 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 0/8] Improve tag change completion\r
+Message-ID: <20131023001952.GD20337@mit.edu>\r
+References: <1382471457-26056-1-git-send-email-amdragon@mit.edu>\r
+ <87mwm1x9pi.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87mwm1x9pi.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT0dURSw8yWPjTymL1XB6L6zdnMjsw\r
+ eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGQeeL2ctWCdR8W7hLvYGxrXCXYycHBICJhLN\r
+ r56xQdhiEhfurQezhQT2MUqs+lXVxcgFZG9klPjwvokRwjnNJHG/t4kdwlnCKPGj7xYLSAuL\r
+ gKrEr9dzmEFsNgENiW37lzOC2CICOhK3Dy1gB7GZBaQlvv1uZgKxhQXMJCY+7GcFsXmBaiYc\r
+ nwMU5wAaGifReF4PIiwocXLmExaIVi2JG/9egpWAjFn+jwMkzAm06eHxDrBNogIqElNObmOb\r
+ wCg0C0n3LCTdsxC6FzAyr2KUTcmt0s1NzMwpTk3WLU5OzMtLLdI11cvNLNFLTSndxAgOaRel\r
+ HYw/DyodYhTgYFTi4X3QkhYkxJpYVlyZe4hRkoNJSZRXnT89SIgvKT+lMiOxOCO+qDQntfgQ\r
+ owQHs5IIb7MvUDlvSmJlVWpRPkxKmoNFSZz3Fod9kJBAemJJanZqakFqEUxWhoNDSYJXTBRo\r
+ qGBRanpqRVpmTglCmomDE2Q4D9BwY5Aa3uKCxNzizHSI/ClGRSlx3psiQAkBkERGaR5cLyzl\r
+ vGIUB3pFmPcLSBUPMF3Bdb8CGswENHjKEpCri0sSEVJSDYzZUXrvM4LUklZ4910u69/ZdOPt\r
+ 9qR5OQcUnE82MsZ/v8sk+V+X1WB1eH/Tn33TxDK82hSZGqO9NnR3RG2oT3faqGj2VLeq9cgV\r
+ 18Ov9ZTfBN2wiPxVUXwyu/uR0A3b5Gd717zbfvL4hu5Nq+QPf+hYWfbDfPI7d8O08PBfWd9y\r
+ lGTeVHyYc1eJpTgj0VCLuag4EQDI3bfwFAMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 Oct 2013 00:20:05 -0000\r
+\r
+Quoth Mark Walters on Oct 22 at 10:43 pm:\r
+> This looks good to me +1. It makes the code clearer and nicer to read as\r
+> well as giving a better user experience, and it is makes fixing the long\r
+> standing tagging races simpler.\r
+> \r
+> I have a couple of docstring comments:\r
+> \r
+> In patch 2 perhaps notmuch-tag-completions could have a docstring.\r
+\r
+Added. I noticed that I had failed to update the call from\r
+`notmuch-select-tag-with-completion', so I fixed that, too. I don't\r
+understand why we take lists of search terms in random places and\r
+never use more than one element, but I suppose this series doesn't\r
+make that any worse.\r
+\r
+> In Patch 4 I think the docstring for notmuch-search-tag is outdated: it\r
+> is "Change tags for the currently selected thread or region." but \r
+> beg and end can now be specified by the caller.\r
+\r
+I've left the first sentence as it is, since it's good interactive\r
+documentation and a typical way to describe functions even if they\r
+take a region as arguments (see, for example, `kill-region'). But\r
+I've elaborated the rest of the docstring to be clearer about this.\r
+\r
+> and one actual comment:\r
+> \r
+> in patch 3 (for show) delete-dups is called before the list is passed to\r
+> notmuch-read-tag-changes whereas it is not for search or pick.\r
+> Obviously this is not actually a problem but it might be worth being\r
+> consistent.\r
+\r
+Ah, whoops. I'd done this before I decided to handle duplicates in\r
+`notmuch-read-tag-changes'. Since it's redundant, I've removed it.\r
+\r
+> But that was all I found. All tests pass and everything I try behaves\r
+> exactly as expected.\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> \r
+> On Tue, 22 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > This series improves tag change completion in various ways for\r
+> > commands like +, -, and *.\r
+> >\r
+> > From a user perspective, this provides command-specific prompts like\r
+> > "Tag message" and "Tag all" instead of the generic "Tag" prompt, and\r
+> > bases tag removal completions on the tags that are in the buffer,\r
+> > rather than the current tags in the database, providing a more\r
+> > predicable experience.\r
+> >\r
+> > From an implementation perspective, this new tag removal completion\r
+> > behavior improves efficiency and eliminates a road block to fixing the\r
+> > tagging race bug (which otherwise results in massive queries just to\r
+> > compute removal completions). The new code is also more "Elispy" and\r
+> > predictable because all tag change prompting now occurs at the\r
+> > interactive entry points, rather than buried under several layers of\r
+> > non-interactive calls.\r
+> >\r
+> > This is a spiritual successor to\r
+> > id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com, though\r
+> > it takes a very different approach. This is also a prerequisite to\r
+> > the tag race fix in\r
+> > id:1381185201-25197-1-git-send-email-amdragon@mit.edu and I plan to\r
+> > send an updated version of that series when this one is accepted.\r
+> >\r
+> > Patches 1, 5, and 6 could be pushed on their own. They fix bugs or\r
+> > sort of bugs that get in the way of the rest of the series.\r
projects / notmuch-archives.git / commitdiff