--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id E6D5F431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 26 Nov 2012 09:35:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id HNF8Y9zxu782 for <notmuch@notmuchmail.org>;\r
+ Mon, 26 Nov 2012 09:35:14 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+ [18.7.68.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id 4737E431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 26 Nov 2012 09:35:14 -0800 (PST)\r
+X-AuditID: 12074424-b7fbe6d000003b02-22-50b3a851d8d7\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+ by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id AD.24.15106.158A3B05; Mon, 26 Nov 2012 12:35:13 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qAQHZCsH004081; \r
+ Mon, 26 Nov 2012 12:35:13 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qAQHZ8Zx000062\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Mon, 26 Nov 2012 12:35:11 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1Td2aK-0001T5-BF; Mon, 26 Nov 2012 12:35:08 -0500\r
+Date: Mon, 26 Nov 2012 12:35:08 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 0/6] API for iterating over all messages in a thread\r
+Message-ID: <20121126173508.GQ4562@mit.edu>\r
+References: <1353819427-13182-1-git-send-email-amdragon@mit.edu>\r
+ <87ehjhkb3a.fsf@qmul.ac.uk> <20121125212059.GN4562@mit.edu>\r
+ <m2624sffj1.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <m2624sffj1.fsf@guru.guru-group.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hRV1g1csTnAoPOTmMXquTwW12/OZLZ4\r
+ s3IeqwOzx85Zd9k9Dn9dyOLxbNUt5gDmKC6blNSczLLUIn27BK6M/+u2sxV8kqr4f+c3YwPj\r
+ R5EuRk4OCQETiQsNn5ghbDGJC/fWs3UxcnEICexjlDh7qZ8VwtnAKHHl4lFGCOcik8Slw0uZ\r
+ IZwljBL9vw4xgfSzCKhK9KyZwwpiswloSGzbv5wRxBYRUJF40LYeLM4s4Cox48IusHphAQ+J\r
+ B79/gtm8AtoSVz5vZoIYuoxRovfLFFaIhKDEyZlPWCCatSRu/HsJVMQBZEtLLP/HARLmFDCQ\r
+ mHv1BTuILQq0a8rJbWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRbrm\r
+ ermZJXqpKaWbGEHBzu6isoOx+ZDSIUYBDkYlHt4DSzYHCLEmlhVX5h5ilORgUhLl3TMXKMSX\r
+ lJ9SmZFYnBFfVJqTWnyIUYKDWUmE93sjUI43JbGyKrUoHyYlzcGiJM57PeWmv5BAemJJanZq\r
+ akFqEUxWhoNDSYLXdTlQo2BRanpqRVpmTglCmomDE2Q4D9BwX5Aa3uKCxNzizHSI/ClGRSlx\r
+ XneQhABIIqM0D64XloxeMYoDvSLMmwVSxQNMZHDdr4AGMwENTr6+EWRwSSJCSqqBsY43JPma\r
+ EnfadT2xikyR2QfsJ6+IiHjlGhl/9NKPeNcZ84TsW5Z/jSxjDAut6XN4fPzXX0U/8SVvNGIm\r
+ 7rt5Lax2t32e0O7jnGeTlV6dufziQ5z0QWPu+WxCVtdiTvzt91iaeo5v75XJqqvLm6bJ7bBm\r
+ /3ekV3re/b1PP7BZayu87JZhZ5rDrMRSnJFoqMVcVJwIAIvw24QhAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Nov 2012 17:35:15 -0000\r
+\r
+Quoth Tomi Ollila on Nov 26 at 7:19 pm:\r
+> On Sun, Nov 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> \r
+> > Quoth Mark Walters on Nov 25 at 2:31 pm:\r
+> >> \r
+> >> Hi\r
+> >> \r
+> >> This series looks good to me (I have not reviewed the two bindings\r
+> >> patches). Patch 2 looks like it makes things much easier to follow than\r
+> >> the current code (if I understood the current pointer stuff it\r
+> >> constructs the top-level list by doing pointer stuff to remove all\r
+> >> messages which are replies from the complete message list). Indeed, the\r
+> >> diff is more complicated than the new code!\r
+> >> \r
+> >> On Sun, 25 Nov 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> >> > This series adds a library API for iterating over all messages in a\r
+> >> > thread in sorted order. This is easy for the library to provide and\r
+> >> > difficult to obtain from the current API. Plus, if you don't count\r
+> >> > the code added to the bindings, this series is actually a net\r
+> >> > decrease of 4 lines of code because of simplifications it enables.\r
+> >> >\r
+> >> > Do we want the API to do more? Currently it's very minimal, but I can\r
+> >> > imagine two ways it could be generalized. It could take an argument\r
+> >> > to indicate which message list to return, which could be all messages,\r
+> >> > matched messages, top-level messages, or maybe even unmatched messages\r
+> >> > (possibly all in terms of message flags). It could also take an\r
+> >> > argument indicating the desired sort order. Currently, the caller can\r
+> >> > use existing message flag APIs to distinguish matched and unmatched\r
+> >> > messages and there's a separate function for the top-level messages.\r
+> >> > However, if the API could do all of these things, it would subsume\r
+> >> > various other API functions, such as notmuch_thread_get_*_date.\r
+> >> \r
+> >> I don't know if this is the right API. For the matched message etc I\r
+> >> think using the existing message flag APIs is simple enough. I am not\r
+> >> sure about sort orders though: that looks like it would be much easier\r
+> >> for the caller to have the correct sort by I am not sure what users\r
+> >> would need it.\r
+> >\r
+> > For sort order, I would be inclined to simply construct the reverse\r
+> > list the first time a caller asks for it. Theoretically the caller\r
+> > could do this just as easily as the library, except that we don't\r
+> > expose the list routines.\r
+> >\r
+> > If I do add sort order, I would also want to add some control over\r
+> > which list is returned, since it would be asymmetric to be able to\r
+> > request all messages in either order, but top-level messages only in\r
+> > oldest-first. I think this would be pretty simple, and would give us\r
+> > a reasonably general-purpose and extensible API. (It would also solve\r
+> > the naming conundrum I mentioned below in my original email.)\r
+> \r
+> The code looks good to me. \r
+> \r
+> I'm interested to see the extensible interface for returning desired\r
+> list in desired sort order :)\r
+\r
+I'll give this a shot (probably later today) and people can see what\r
+they think.\r
+\r
+> Tomi\r
+> \r
+> >\r
+> >> Best wishes\r
+> >> \r
+> >> Mark\r
+> >> \r
+> >> \r
+> >> >\r
+> >> > Also, is this the right name for the new API? In particular, if we do\r
+> >> > later want to add a function that returns, say, the list of matched\r
+> >> > messages, we'll have a convention collision with\r
+> >> > notmuch_thread_get_matched_messages, which returns only a count.\r
projects / notmuch-archives.git / commitdiff