Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather...

diff --git a/1c/9b12487acfedcfc80f55317843e21ea4c16a7d b/1c/9b12487acfedcfc80f55317843e21ea4c16a7d
new file mode 100644 (file)
index 0000000..5fb40df
--- /dev/null
+++ b/1c/9b12487acfedcfc80f55317843e21ea4c16a7d
@@ -0,0 +1,90 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EC738429E55\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 07:34:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id N2zcNEJ+PPA0 for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Jun 2013 07:34:18 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 95C53429E4C\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 07:34:18 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id EF418100030;\r
+       Sun,  2 Jun 2013 17:34:17 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: bugfix. use\r
+       notmuch-show-only-matching-messages rather than prefix\r
+In-Reply-To: <1370123491-13902-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1370123491-13902-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 02 Jun 2013 17:34:17 +0300\r
+Message-ID: <m2a9n8d1jq.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Jun 2013 14:34:24 -0000\r
+\r
+On Sun, Jun 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> Previously pick set a prefix argument prior to calling show in the\r
+> message pane to tell show to only show matching messages. This sets\r
+> notmuch-show-only-matching-messages instead which is much cleaner and\r
+> will work even if the user has configured show to default to showing\r
+> only matching messages.\r
+> ---\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+\r
+>  contrib/notmuch-pick/notmuch-pick.el |    4 ++--\r
+>  1 files changed, 2 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+> index 9079acf..2da43ea 100644\r
+> --- a/contrib/notmuch-pick/notmuch-pick.el\r
+> +++ b/contrib/notmuch-pick/notmuch-pick.el\r
+> @@ -376,8 +376,8 @@ Does NOT change the database."\r
+>          (split-window-vertically (/ (window-height) 4)))\r
+>        (with-selected-window notmuch-pick-message-window\r
+>      ;; Since we are only displaying one message do not indent.\r
+> -    (let ((notmuch-show-indent-messages-width 0))\r
+> -      (setq current-prefix-arg '(4))\r
+> +    (let ((notmuch-show-indent-messages-width 0)\r
+> +          (notmuch-show-only-matching-messages t))\r
+>        (setq buffer (notmuch-show id nil nil nil))))\r
+>        ;; We need the `let' as notmuch-pick-message-window is buffer local.\r
+>        (let ((window notmuch-pick-message-window))\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r