Re: [PATCH 2/6] lib: Add per-message last modification tracking

diff --git a/d0/eb35281a41475ccdf46bd7997eff8893872a55 b/d0/eb35281a41475ccdf46bd7997eff8893872a55
new file mode 100644 (file)
index 0000000..0a08e7b
--- /dev/null
+++ b/d0/eb35281a41475ccdf46bd7997eff8893872a55
@@ -0,0 +1,107 @@
+Return-Path: <daniel@schoepe.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 946D26DE13F4\r
+ for <notmuch@notmuchmail.org>; Fri,  7 Aug 2015 00:36:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.207\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.207 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01,\r
+ RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_WEB=0.614, SPF_PASS=-0.001]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id oBBjEt9tRNqq for <notmuch@notmuchmail.org>;\r
+ Fri,  7 Aug 2015 00:36:26 -0700 (PDT)\r
+Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com\r
+ [209.85.212.172])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id CABB16DE13E7\r
+ for <notmuch@notmuchmail.org>; Fri,  7 Aug 2015 00:36:25 -0700 (PDT)\r
+Received: by wibhh20 with SMTP id hh20so54251705wib.0\r
+ for <notmuch@notmuchmail.org>; Fri, 07 Aug 2015 00:36:24 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=Fd+divPZykzAv+3krtzugtjX+s+SYsjERjJteU15k/w=;\r
+ b=e9Uvpm4TmXeRH7zy+U432IOMP1DLFiR6nJWIW2zhODEfAQ7nVG+8yWmYgnq9vnEVLk\r
+ yWh0HM9fOEALK1bswkdZBU8R4f7tABVULt4/LChWJnk0VsH7s3VC4X3Lz9jXWyrxVIYt\r
+ pFSe3jEraotZx5GLhO75NyolBXOc16tutNMTY=\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type;\r
+ bh=Fd+divPZykzAv+3krtzugtjX+s+SYsjERjJteU15k/w=;\r
+ b=bwy5UQI+djX7l2H64Z0VbQVHaTFown1nXr+P7cPK5bW5Pe4RxQdNfggzQvHDdBKaiP\r
+ 7iVPus7SfwAkq8WYQDDttFGQXpM51tJhtykzUx770UwqxMM9140dpwcdgFloCKqIhwRQ\r
+ q28Iak2W5+aEcIXeh5dhWJZCVbOX3Vdhms2zxnhss6Wnsp9L8rDRBEC6S1v1MSzOAa+0\r
+ 10Z0S04VMev4Wd07mo71aPzPGhIm14gkVhiZToDYl2w9brKc0dynlosO72dS/Lzw4c9k\r
+ ZJkG62RHtm4H/1D6Lu2KBh/a9SEp4/b1aHDI2ZCWXy/QJioKIGfXBu2TQrMsv7h5q1Bk\r
+ DA8w==\r
+X-Gm-Message-State:\r
+ ALoCoQmUWrzV6ilrONfdwPd+N/Wj1MKc8T5BwhkSMyosFZc6jVnIjWbTlCXaLmLSkn330caS7/E5\r
+X-Received: by 10.180.19.65 with SMTP id c1mr3462238wie.15.1438932983582;\r
+ Fri, 07 Aug 2015 00:36:23 -0700 (PDT)\r
+Received: from localhost (ip-80-226-24-9.vodafone-net.de. [80.226.24.9])\r
+ by smtp.gmail.com with ESMTPSA id o9sm13269327wja.29.2015.08.07.00.36.20\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Fri, 07 Aug 2015 00:36:22 -0700 (PDT)\r
+From: Daniel Schoepe <daniel@schoepe.org>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/6] lib: Add per-message last modification tracking\r
+In-Reply-To: <1433525318-23756-3-git-send-email-david@tethera.net>\r
+References: <1432936375-astroid-4-0i1n6yczs2-1520@strange>\r
+ <1433525318-23756-1-git-send-email-david@tethera.net>\r
+ <1433525318-23756-3-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+Date: Fri, 07 Aug 2015 09:36:18 +0200\r
+Message-ID: <878u9nk0st.fsf@schoepe.localhost>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 07 Aug 2015 07:36:28 -0000\r
+\r
+Hi,\r
+\r
+On Fri, 05 Jun 2015 19:28 +0200, David Bremner wrote:\r
+> +        /* Prior to NOTMUCH_FEATURE_LAST_MOD, messages did not\r
+> +         * track modification revisions.  Give all messages a\r
+> +         * revision of 1.\r
+> +         */\r
+> +        if (new_features & NOTMUCH_FEATURE_LAST_MOD)\r
+> +            _notmuch_message_upgrade_last_mod (message);\r
+> [..]\r
+> +/* Upgrade a message to support NOTMUCH_FEATURE_LAST_MOD.  The caller\r
+> + * must call _notmuch_message_sync. */\r
+> +void\r
+> +_notmuch_message_upgrade_last_mod (notmuch_message_t *message)\r
+> +{\r
+> +    /* _notmuch_message_sync will update the last modification\r
+> +     * revision; we just have to ask it to. */\r
+> +    message->modified = TRUE;\r
+> +}\r
+> +\r
+\r
+The comment in the first part says that message without LAST_MOD get a\r
+revision of 1, but as far as I can tell, _notmuch_message_sync will\r
+actually put the next revision number on the message. If this is what's\r
+happening, either the comment or the behavior should be changed,\r
+depending on what's intended.\r
+\r
+Best regards,\r
+Daniel\r