Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general refactoring

diff --git a/17/1c40b0a73896aa18cbfa01276c8945c998c56e b/17/1c40b0a73896aa18cbfa01276c8945c998c56e
new file mode 100644 (file)
index 0000000..03636d9
--- /dev/null
+++ b/17/1c40b0a73896aa18cbfa01276c8945c998c56e
@@ -0,0 +1,111 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B008431FBC\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Feb 2014 07:00:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WhTFB5yGozl6 for <notmuch@notmuchmail.org>;\r
+       Wed,  5 Feb 2014 07:00:51 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id A2A2F431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Feb 2014 07:00:51 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9B119100033;\r
+       Wed,  5 Feb 2014 17:00:45 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH 00/17] nmbug-status: Python-3-compabitility and general\r
+       refactoring\r
+In-Reply-To: <m2fvnywsly.fsf@guru.guru-group.fi>\r
+References: <cover.1391424512.git.wking@tremily.us>\r
+       <m2ha8frjgg.fsf@guru.guru-group.fi>\r
+       <20140204005331.GQ14197@odin.tremily.us>\r
+       <m2fvnzp3uh.fsf@guru.guru-group.fi>\r
+       <20140204161142.GS14197@odin.tremily.us>\r
+       <m2a9e6zppp.fsf@guru.guru-group.fi>\r
+       <20140204191453.GV14197@odin.tremily.us>\r
+       <m2fvnywsly.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 05 Feb 2014 17:00:45 +0200\r
+Message-ID: <m2fvnxvc2q.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Feb 2014 15:00:59 -0000\r
+\r
+On Tue, Feb 04 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+\r
+> On Tue, Feb 04 2014, "W. Trevor King" <wking@tremily.us> wrote:\r
+>\r
+>\r
+> $ PYTHONPATH=$PWD/bindings/python/ ./devel/nmbug/nmbug-status\r
+> ...\r
+> Traceback (most recent call last):\r
+>   File "devel/nmbug/nmbug-status", line 318, in <module>\r
+>     page.write(database=db, views=config['views'])\r
+>   File "devel/nmbug/nmbug-status", line 94, in write\r
+>     self._write_view(database=database, view=view, stream=stream)\r
+>   File "devel/nmbug/nmbug-status", line 113, in _write_view\r
+>     self._write_threads(threads=threads, stream=stream)\r
+>   File "devel/nmbug/nmbug-status", line 215, in _write_threads\r
+>     ).format(**message_display_data))\r
+>   File "/usr/lib64/python2.6/codecs.py", line 351, in write\r
+>     data, consumed = self.encode(object, self.errors)\r
+> UnicodeEncodeError: 'ascii' codec can't encode character u'\u017b' in\r
+> position 176: ordinal not in range(128)\r
+>\r
+>\r
+> I'll dig deeper tomorrow.\r
+\r
+PEBKAC. I (actually) used wrapper to run nmbug-status -- to run right\r
+notmuch binary. While it mostly sets environment to be right it internally\r
+uses LC_ALL=C for consistency -- and the wrapper forgot to restore\r
+LC_ALL before running nmbug-status.\r
+\r
+(that also confirms that the suggestion you made I used cron was somewhat\r
+accurate ;)\r
+\r
+After I fixed the wrapper the program works fine on python 2.6.6.\r
+\r
+I have some comments on the new look -- which is pretty nice btw.\r
+\r
+now every other thread is background-colored (girly) pink (fef?)\r
+and every other light blue (eff). for me the light blue is not\r
+visible (there are no body background color set?)\r
+\r
+... hmm, i added 'body { background-color: #FFF; }' to the page and\r
+still light blue is not visible on my screen (checked w/ #f0f that\r
+the above line actually has some effect)... #DFF for the light-blue\r
+works better for me.\r
+\r
+I think rounded corners are nice but IMHO the round radius is too big\r
+-- using 0.5mm for the radius would IMHO be better.\r
+\r
+>\r
+> Tomi\r
+\r
+Tomi\r