--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0C550431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 20 Oct 2014 12:05:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Ex0-5RiIuOVR for <notmuch@notmuchmail.org>;\r
+ Mon, 20 Oct 2014 12:05:52 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1F60C431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 20 Oct 2014 12:05:52 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id ADE0B10008C;\r
+ Mon, 20 Oct 2014 22:05:32 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Franz Fellner <alpine.art.de@gmail.com>\r
+Subject: Re: [PATCH] VIM: Add URI handling\r
+In-Reply-To: <20141017181422.GG20696@TP_L520.localdomain>\r
+References: <1412281423-22441-1-git-send-email-imain@stemwinder.org>\r
+ <20141010114457.GG28601@TP_L520.localdomain>\r
+ <543822f73d3fd_46ad163fe88cd@ovo.mains.priv.notmuch>\r
+ <20141011142943.GD23373@TP_L520.localdomain>\r
+ <543ecc23bb98_2c291569e8c17@ovo.mains.priv.notmuch>\r
+ <20141017181422.GG20696@TP_L520.localdomain>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 20 Oct 2014 22:05:32 +0300\r
+Message-ID: <m2vbner283.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 20 Oct 2014 19:05:56 -0000\r
+\r
+On Fri, Oct 17 2014, Franz Fellner <alpine.art.de@gmail.com> wrote:\r
+\r
+> On Wed, 15 Oct 2014 12:33:55 -0700, Ian Main <imain@stemwinder.org> wrote:\r
+>> Franz Fellner wrote:\r
+>> > Here is a working implementation.\r
+>> > Please review carefully as I only can simulate ruby and vimscript\r
+>> > knowledge from what I see in notmuch.vim sourcefile and quick\r
+>> > googling.\r
+>> \r
+>> Yes, this works nicely. Thanks!\r
+>> \r
+>> I do notice however that this is against the github plugin repo (I think)?\r
+> Yes, that's right.\r
+> I forked the notmuch repo on github and incorporated your patches.\r
+> Already made a mistake while applying one of your patches...\r
+> https://github.com/ff2000/notmuch\r
+> (Hope everythin is fine now)\r
+> \r
+> commit cb757e9e438341a7bc6d2cfec4de7bdcc85946ea\r
+> Author: Franz Fellner <alpine.art.de@gmail.com>\r
+> Date: Fri Oct 17 11:19:41 2014 +0200\r
+>\r
+> VIM: Add MsgID to supported URIs\r
+\r
+Code-wise this patch looks good -- although I am not entirely sure what id\r
+does -- I expect it to handle id:... links...\r
+\r
+This email applies with git am (on top of Ian's) but the commit message has\r
+quite a few lines of cruft -- I'd like to see a commit message what\r
+explains what this change do ( the term 'MsgID' seems to be some vim client\r
+internal (subclass in URI class ?) which IMO should be better commented in\r
+this commit message.\r
+\r
+\r
+Tomi\r
+\r
+>\r
+> diff --git a/vim/notmuch.vim b/vim/notmuch.vim\r
+> index 6287cf6..30e1876 100644\r
+> --- a/vim/notmuch.vim\r
+> +++ b/vim/notmuch.vim\r
+> @@ -268,6 +268,14 @@ ruby << EOF\r
+> if uri.class == URI::MailTo\r
+> vim_puts("Composing new email to #{uri.to}.")\r
+> VIM::command("call s:compose('#{uri.to}')")\r
+> + elsif uri.class == URI::MsgID\r
+> + msg = $curbuf.message(uri.opaque)\r
+> + if !msg\r
+> + vim_puts("Message not found in NotMuch database: #{uri.to_s}")\r
+> + else\r
+> + vim_puts("Opening message #{msg.message_id} in thread #{msg.thread_id}.")\r
+> + VIM::command("call s:show('thread:#{msg.thread_id}', '#{msg.message_id}')")\r
+> + end\r
+> else\r
+> vim_puts("Opening #{uri.to_s}.")\r
+> cmd = VIM::evaluate('g:notmuch_open_uri')\r
+> @@ -428,11 +436,12 @@ endfunction\r
+> \r
+> "" main\r
+> \r
+> -function! s:show(thread_id)\r
+> +function! s:show(thread_id, msg_id)\r
+> call s:new_buffer('show')\r
+> setlocal modifiable\r
+> ruby << EOF\r
+> thread_id = VIM::evaluate('a:thread_id')\r
+> + msg_id = VIM::evaluate('a:msg_id')\r
+> $cur_thread = thread_id\r
+> $messages.clear\r
+> $curbuf.render do |b|\r
+> @@ -464,6 +473,9 @@ ruby << EOF\r
+> end\r
+> b << ""\r
+> nm_m.end = b.count\r
+> + if !msg_id.empty? and nm_m.message_id == msg_id\r
+> + VIM::command("normal #{nm_m.start}zt")\r
+> + end\r
+> end\r
+> b.delete(b.count)\r
+> end\r
+> @@ -486,7 +498,7 @@ ruby << EOF\r
+> when 1; $cur_filter = nil\r
+> when 2; $cur_filter = $cur_search\r
+> end\r
+> - VIM::command("call s:show('#{id}')")\r
+> + VIM::command("call s:show('#{id}', '')")\r
+> EOF\r
+> endfunction\r
+> \r
+> @@ -910,6 +922,10 @@ ruby << EOF\r
+> q\r
+> end\r
+> \r
+> + def message(id)\r
+> + @db.find_message(id)\r
+> + end\r
+> +\r
+> def close\r
+> @queries.delete_if { |q| ! q.destroy! }\r
+> @db.close\r
+> @@ -930,6 +946,13 @@ ruby << EOF\r
+> end\r
+> end\r
+> \r
+> + module URI\r
+> + class MsgID < Generic\r
+> + end\r
+> +\r
+> + @@schemes['ID'] = MsgID\r
+> + end\r
+> +\r
+> class Message\r
+> attr_accessor :start, :body_start, :end\r
+> attr_reader :message_id, :filename, :mail\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff