Re: [PATCH v4 0/6] Config-related patches

diff --git a/28/8c64cbc2b932e146db9eb10a3338574054bb27 b/28/8c64cbc2b932e146db9eb10a3338574054bb27
new file mode 100644 (file)
index 0000000..c1cbc2b
--- /dev/null
+++ b/28/8c64cbc2b932e146db9eb10a3338574054bb27
@@ -0,0 +1,122 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7E007431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Apr 2012 01:25:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7nBHU4XNnyTH for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Apr 2012 01:25:51 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BCF07431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Apr 2012 01:25:50 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SIyIi-0004dT-9m; Sat, 14 Apr 2012 09:25:46 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SIyIi-0002XA-0W; Sat, 14 Apr 2012 09:25:44 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 0/6] Config-related patches\r
+In-Reply-To: <1334367666-10954-1-git-send-email-novalazy@gmail.com>\r
+References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>\r
+       <1334367666-10954-1-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 14 Apr 2012 09:25:52 +0100\r
+Message-ID: <87zkaelnxr.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 68ad0dbbae8ef18ebd66d0384a461600 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Apr 2012 08:25:51 -0000\r
+\r
+On Sat, 14 Apr 2012, Peter Wang <novalazy@gmail.com> wrote:\r
+> Changes from v3:\r
+> - rephrase part of the 'list' implementation as a separate patch\r
+> - test 'set' on an extant key\r
+> - test removing keys\r
+\r
+This looks good to me. +1\r
+\r
+Two minor comments which you might like to consider (but definitely are\r
+not required):\r
+    1) You could check that there are no further arguments when the user\r
+    calls `notmuch config list'\r
+    2) In the man page you could explicitly say what the output is for a\r
+    configuration item which has not been set.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+    \r
+\r
+\r
+> Peter Wang (6):\r
+>   config: Fix free in 'config get' implementation.\r
+>   config: Check 'config get' arity exactly\r
+>   test: Add tests for 'config' command\r
+>   test: Add broken test for 'config list'\r
+>   config: Add 'config list' command\r
+>   man: Document 'config list' command\r
+>\r
+>  man/man1/notmuch-config.1 |   14 +++++++++\r
+>  notmuch-config.c          |   68 +++++++++++++++++++++++++++++++++++++++++---\r
+>  test/config               |   60 +++++++++++++++++++++++++++++++++++++++\r
+>  test/notmuch-test         |    1 +\r
+>  4 files changed, 138 insertions(+), 5 deletions(-)\r
+>  create mode 100755 test/config\r
+>\r
+> -- \r
+> 1.7.4.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r