Re: [PATCH 1/3] Add notmuch_database_close_compact

diff --git a/c3/e6d9de02b7a17834cdf976a0a5683ea5491805 b/c3/e6d9de02b7a17834cdf976a0a5683ea5491805
new file mode 100644 (file)
index 0000000..92fe83f
--- /dev/null
+++ b/c3/e6d9de02b7a17834cdf976a0a5683ea5491805
@@ -0,0 +1,90 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C5D26431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 23:07:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id aYOfwdBOQnYS for <notmuch@notmuchmail.org>;\r
+       Tue, 21 Aug 2012 23:07:06 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id B50D6431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 23:07:06 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 2B332100386; Wed, 22 Aug 2012 09:07:14 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ben Gamari <bgamari.foss@gmail.com>, notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 1/3] Add notmuch_database_close_compact\r
+In-Reply-To: <87y5l8z4dw.fsf@gmail.com>\r
+References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com>\r
+       <1345476704-17091-2-git-send-email-bgamari.foss@gmail.com>\r
+       <m27gssitot.fsf@guru.guru-group.fi> <87y5l8z4dw.fsf@gmail.com>\r
+User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 22 Aug 2012 09:07:14 +0300\r
+Message-ID: <m2txvv794d.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 22 Aug 2012 06:07:11 -0000\r
+\r
+On Tue, Aug 21 2012, Ben Gamari wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> On Mon, Aug 20 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:\r
+>>\r
+>\r
+>> Hmm, I guess the check above is to determine whether xapian version is\r
+>> 1.2.6 or newer, but is there xapian version 1.1.6 or 1.0.6 or 0.3.0 or so ?\r
+>>\r
+> Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the\r
+> public API.\r
+\r
+The comparison code\r
+\r
+>>> if [ "${xapian_major_version}" -gt 1 ] || \r
+>>>    [ ${xapian_minor_version} -gt 2 ] || \r
+>>>    [ ${xapian_subminor_version} -ge 6 ]; then\r
+\r
+would match e.g. 1.1.6, 1.0.6 and 0.3.0\r
+\r
+Presuming that those variables are always numeric the comparison could be:\r
+\r
+if [ ${xapian_major_version} -gt 1 ] || \r
+   [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -gt 2 ] || \r
+   [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -eq 2 -a \\r
+     ${xapian_subminor_version} -ge 6 ]; then\r
+\r
+(I could not figure out anything shorter and/or cleaner)\r
+\r
+>\r
+> Thanks!\r
+>\r
+> Cheers,\r
+>\r
+> - Ben\r
+\r
+\r
+Tomi\r