--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D1F41431FDD\r
+ for <notmuch@notmuchmail.org>; Thu, 4 Jul 2013 01:07:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id gf7PjwaIwF2w for <notmuch@notmuchmail.org>;\r
+ Thu, 4 Jul 2013 01:07:32 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 59B32431FBF\r
+ for <notmuch@notmuchmail.org>; Thu, 4 Jul 2013 01:07:32 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1UueZa-0003uY-7D; Thu, 04 Jul 2013 09:07:28 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1UueZZ-0007tU-VZ; Thu, 04 Jul 2013 09:07:26 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: use notmuch-start-notmuch\r
+In-Reply-To: <m2zju2lqpy.fsf@guru.guru-group.fi>\r
+References: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com>\r
+ <m2zju2lqpy.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Thu, 04 Jul 2013 09:07:24 +0100\r
+Message-ID: <87ip0qg343.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: b34aa5a27364e928f28a4ee6b6f8d364 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 04 Jul 2013 08:07:41 -0000\r
+\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> FWIW the code LGTM. Do the pick tests use this and do those pass ?\r
+\r
+Thanks for the review.\r
+\r
+The tests do all pass. There are two sets of pick tests: one uses the\r
+async parser (the default) which uses this code and the other uses the\r
+sync parser (which probably should be removed as the async parser seems\r
+stable).\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+\r
+\r
+>\r
+> Tomi\r
+>\r
+>>\r
+>> Best wishes\r
+>>\r
+>> Mark\r
+>>\r
+>>\r
+>> contrib/notmuch-pick/notmuch-pick.el | 7 +++----\r
+>> 1 files changed, 3 insertions(+), 4 deletions(-)\r
+>>\r
+>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+>> index fbd7c0b..7f5f729 100644\r
+>> --- a/contrib/notmuch-pick/notmuch-pick.el\r
+>> +++ b/contrib/notmuch-pick/notmuch-pick.el\r
+>> @@ -817,16 +817,15 @@ Complete list of currently available key bindings:\r
+>> (if (equal (car (process-lines notmuch-command "count" search-args)) "0")\r
+>> (setq search-args basic-query))\r
+>> (if notmuch-pick-asynchronous-parser\r
+>> - (let ((proc (start-process\r
+>> - "notmuch-pick" buffer\r
+>> - notmuch-command "show" "--body=false" "--format=sexp"\r
+>> + (let ((proc (notmuch-start-notmuch\r
+>> + "notmuch-pick" buffer #'notmuch-pick-process-sentinel\r
+>> + "show" "--body=false" "--format=sexp"\r
+>> message-arg search-args))\r
+>> ;; Use a scratch buffer to accumulate partial output.\r
+>> ;; This buffer will be killed by the sentinel, which\r
+>> ;; should be called no matter how the process dies.\r
+>> (parse-buf (generate-new-buffer " *notmuch pick parse*")))\r
+>> (process-put proc 'parse-buf parse-buf)\r
+>> - (set-process-sentinel proc 'notmuch-pick-process-sentinel)\r
+>> (set-process-filter proc 'notmuch-pick-process-filter)\r
+>> (set-process-query-on-exit-flag proc nil))\r
+>> (progn\r
+>> -- \r
+>> 1.7.9.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff