--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 9A39B431FC2\r
+ for <notmuch@notmuchmail.org>; Fri, 25 Oct 2013 01:04:29 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id DxMiC2jp3JlV for <notmuch@notmuchmail.org>;\r
+ Fri, 25 Oct 2013 01:04:22 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 20E10431FB6\r
+ for <notmuch@notmuchmail.org>; Fri, 25 Oct 2013 01:04:22 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VZcNT-0002ML-0H; Fri, 25 Oct 2013 09:04:18 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VZcNS-0003WJ-Lw; Fri, 25 Oct 2013 09:04:14 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Add a space after completed tag operations\r
+In-Reply-To: <1382650227-4055-1-git-send-email-amdragon@mit.edu>\r
+References: <1382650227-4055-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 25 Oct 2013 09:04:13 +0100\r
+Message-ID: <8738np7p4y.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: cdaa836c7a501d274c4f9765501ab852 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 25 Oct 2013 08:04:29 -0000\r
+\r
+\r
+Tested and LGTM +1\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+On Thu, 24 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Previously, when a user fully completed a tag operation, they had to\r
+> press space to begin entering another tag operation. This is\r
+> different from, say, shell file name completion, which typically\r
+> inserts a space after an unambiguous completion under the assumption\r
+> that the user will want to enter more input.\r
+>\r
+> This patch tweaks `notmuch-read-tag-changes' to act more like shell\r
+> file name completion: after an unambiguous tag completion, it now\r
+> inserts a space, ready and waiting for another tagging operation from\r
+> the user. This is backwards-compatible with old habits, since there's\r
+> no harm in putting an extra space.\r
+> ---\r
+>\r
+> Just because of the context, this must be applied on top of the\r
+> currently pending tag completion series\r
+> id:"1382487721-31776-1-git-send-email-amdragon@mit.edu". The change\r
+> itself should be otherwise independent.\r
+>\r
+> emacs/notmuch-tag.el | 12 ++++++++++--\r
+> 1 file changed, 10 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+> index 7b21006..8b921f1 100644\r
+> --- a/emacs/notmuch-tag.el\r
+> +++ b/emacs/notmuch-tag.el\r
+> @@ -229,8 +229,16 @@ initial input in the minibuffer."\r
+> (set-keymap-parent map crm-local-completion-map)\r
+> (define-key map " " 'self-insert-command)\r
+> map)))\r
+> - (delete "" (completing-read-multiple prompt\r
+> - tag-list nil nil initial-input\r
+> + (delete "" (completing-read-multiple\r
+> + prompt\r
+> + ;; Append the separator to each completion so when the\r
+> + ;; user completes a tag they can immediately begin\r
+> + ;; entering another. `completing-read-multiple'\r
+> + ;; ultimately splits the input on crm-separator, so we\r
+> + ;; don't need to strip this back off (we just need to\r
+> + ;; delete "empty" entries caused by trailing spaces).\r
+> + (mapcar (lambda (tag-op) (concat tag-op crm-separator)) tag-list)\r
+> + nil nil initial-input\r
+> 'notmuch-read-tag-changes-history))))\r
+> \r
+> (defun notmuch-update-tags (tags tag-changes)\r
+> -- \r
+> 1.8.4.rc3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff