Re: [PATCH 1/3] cli: add insert --must-index option

diff --git a/04/415cdbd0fb8d048922ff5aa5e875b307bf1ee7 b/04/415cdbd0fb8d048922ff5aa5e875b307bf1ee7
new file mode 100644 (file)
index 0000000..d953f98
--- /dev/null
+++ b/04/415cdbd0fb8d048922ff5aa5e875b307bf1ee7
@@ -0,0 +1,77 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 54885431FBF\r
+       for <notmuch@notmuchmail.org>; Thu, 10 Oct 2013 07:15:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id UIgK0zk2s36v for <notmuch@notmuchmail.org>;\r
+       Thu, 10 Oct 2013 07:15:12 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6FC26431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 10 Oct 2013 07:15:12 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VUH1B-0002NG-Gh; Thu, 10 Oct 2013 11:15:09 -0300\r
+Received: (nullmailer pid 29797 invoked by uid 1000); Thu, 10 Oct 2013\r
+       14:15:05 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 1/3] cli: add insert --must-index option\r
+In-Reply-To: <m238o9fguj.fsf@guru.guru-group.fi>\r
+References: <1374365254-13227-1-git-send-email-novalazy@gmail.com>\r
+       <87ip048gbj.fsf@qmul.ac.uk> <20130727151510.GA13750@hili.localdomain>\r
+       <87hadtxfrr.fsf@qmul.ac.uk> <20130912001349.GA18821@hili.localdomain>\r
+       <87zjqhv264.fsf@zancas.localnet> <m238o9fguj.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 10 Oct 2013 11:15:05 -0300\r
+Message-ID: <87bo2xtdp2.fsf@unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 10 Oct 2013 14:15:20 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>> I'm not opposed to doing an SONAME bump for 0.17. Are there other ABI\r
+>> breaking changes that we have been holding back on? Can these maybe go\r
+>> through at the same time?\r
+>\r
+> Maybe something along these lines...\r
+>\r
+> (Quick draft for the API part; to start discussion before working too much\r
+> for something that is going to be dropped...)\r
+>\r
+>  notmuch_status_t\r
+> -notmuch_database_create (const char *path, notmuch_database_t **database);\r
+> +notmuch_database_create (const char *path,\r
+> +                     notmuch_loghook_t *loghook,\r
+> +                     notmuch_database_t **database);\r
+\r
+Another idea floated (by Austin?) was to pass in an options struct, to\r
+allow future options to be added without changing the function\r
+signature. I guess with some care this could be done in an upwardly\r
+compatible way.\r
+\r
+d\r