Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages

diff --git a/2a/69e54e416e52834220dc5527d4375212ba828e b/2a/69e54e416e52834220dc5527d4375212ba828e
new file mode 100644 (file)
index 0000000..92c7824
--- /dev/null
+++ b/2a/69e54e416e52834220dc5527d4375212ba828e
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 15CA5431FC3\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 01:30:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0ToNfnSRcPjS for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Oct 2014 01:30:40 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E5D44431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 01:30:40 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XahDE-0007iE-1w; Sun, 05 Oct 2014 05:30:40 -0300\r
+Received: (nullmailer pid 24641 invoked by uid 1000); Sun, 05 Oct 2014\r
+       08:30:30 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating\r
+       ghost   messages\r
+In-Reply-To: <1412345958-8278-7-git-send-email-aclements@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+       <1412345958-8278-7-git-send-email-aclements@csail.mit.edu>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 05 Oct 2014 10:30:30 +0200\r
+Message-ID: <87fvf2q5p5.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Oct 2014 08:30:45 -0000\r
+\r
+Austin Clements <aclements@csail.mit.edu> writes:\r
+\r
+> +        message->flags &= ~(1 << NOTMUCH_MESSAGE_FLAG_GHOST);\r
+\r
+What do you think about using bit set / clear / read macros?  I don't\r
+insist, but I wonder if it would make this part more readable.\r
+\r
+> +    else if (*i == "Tghost")\r
+> +        message->flags |= (1 << NOTMUCH_MESSAGE_FLAG_GHOST);\r
+> +    else\r
+\r
+It makes me faintly unhappy to have the prefix hardcoded here.\r
+Not sure if there is a sensible solution.\r