Re: [PATCH 3/3] test: implement and document NOTMUCH_TEST_QUIET variable usage

diff --git a/e4/fc5ec68fc7cc179cc96aab6b8a52a9bdc08de6 b/e4/fc5ec68fc7cc179cc96aab6b8a52a9bdc08de6
new file mode 100644 (file)
index 0000000..bd09451
--- /dev/null
+++ b/e4/fc5ec68fc7cc179cc96aab6b8a52a9bdc08de6
@@ -0,0 +1,110 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A224C431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Nov 2013 00:37:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id uXrxqhfSkeYL for <notmuch@notmuchmail.org>;\r
+       Wed, 13 Nov 2013 00:36:57 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BA489431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Nov 2013 00:36:57 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id B61A1100033;\r
+       Wed, 13 Nov 2013 10:36:49 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 3/3] test: implement and document NOTMUCH_TEST_QUIET\r
+       variable usage\r
+In-Reply-To: <20131112230259.GD13399@mit.edu>\r
+References: <1384288868-23903-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1384288868-23903-3-git-send-email-tomi.ollila@iki.fi>\r
+       <20131112230259.GD13399@mit.edu>\r
+User-Agent: Notmuch/0.16+119~g219c55f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 13 Nov 2013 10:36:49 +0200\r
+Message-ID: <m2iovwofz2.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 13 Nov 2013 08:37:02 -0000\r
+\r
+On Wed, Nov 13 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Quoth Tomi Ollila on Nov 12 at 10:41 pm:\r
+>>             return\r
+>>     fi\r
+>>     test_success=$(($test_success + 1))\r
+>> +   if test -n "$NOTMUCH_TEST_QUIET"; then\r
+>> +           return 0\r
+>> +   fi\r
+>>     say_color pass "%-6s" "PASS"\r
+>>     echo " $test_subtest_name"\r
+>>  }\r
+>> @@ -713,6 +719,9 @@ test_failure_ () {\r
+>>             return\r
+>>     fi\r
+>>     test_failure=$(($test_failure + 1))\r
+>> +   if test -n "$NOTMUCH_TEST_QUIET"; then\r
+>> +           print_test_description\r
+>\r
+> This prints the test description for *every* failing test.  Was that\r
+> intentional?  I would think that, ideally, it would be only printed\r
+> before the first failing subtest in a test (maybe by setting a\r
+> variable in print_test_description on the first call and making it\r
+> return immediately if this variable is set?  Then you wouldn't even\r
+> need the condition here, just the call to print_test_description.)\r
+\r
+Your observation is correct.. I thought about it but dropped -- but\r
+as it *increases* the output it should be addressed. My first solution\r
+would be to do:\r
+\r
+print_test_description ()\r
+{\r
+       echo\r
+       echo $this_test: "Testing ${test_description}"\r
+        print_test_description () { : already printed ; }\r
+}\r
+\r
+But I presume this receives some resistance from the audience ;/\r
+\r
+I think this a bit -- this is post 0.17 release stuff anyway...\r
+\r
+>\r
+>> +   fi\r
+>>     test_failure_message_ "FAIL" "$test_subtest_name" "$@"\r
+>>     test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }\r
+>>     return 1\r
+>\r
+> Stylistic nit: The three if's above use two different styles ([ vs\r
+> test and hanging 'then').  OTOH, maybe this is consistent with\r
+> test-lib's inconsistent style.\r
+\r
+It is consistent with test-lib's inconsistent style: most often if []\r
+is used but those places where I used if test just a line before\r
+the diff context there were if test -format used.\r
+\r
+Tomi\r