(no commit message)
authorhttps://www.google.com/accounts/o8/id?id=AItOawmUWmB1M35_jviFvGPYDIH-a-_Al-7OrXM <Daniel@web>
Sat, 16 Jul 2011 01:09:39 +0000 (21:09 -0400)
committeradmin <admin@branchable.com>
Sat, 16 Jul 2011 01:09:39 +0000 (21:09 -0400)
doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn [new file with mode: 0644]

diff --git a/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_add__47__edit_pages.mdwn
new file mode 100644 (file)
index 0000000..0e9d613
--- /dev/null
@@ -0,0 +1,24 @@
+When I added or edited a page, no commit message was written out (Mercurial backend, though I guess it shouldn't matter). This was done for e.g. the `rename` plugin. I made a naive but seemingly working change to `editpage.pm` to add a message.
+
+I modeled the message on `rename.pm`, which used a lowercase initial letter and imperative form of the verb. This is not the case for e.g. the `comment` plugin, which says "Added a comment: ", so I guess there is no strict rule on style in this case.
+
+Diff follows. --[[Daniel Andersson]]
+
+[[!tag patch]]
+
+---
+
+       diff -r ee177ca9bf36 Plugin/editpage.pm
+       --- a/Plugin/editpage.pm        Fri Jul 15 17:58:04 2011 +0200
+       +++ b/Plugin/editpage.pm        Sat Jul 16 03:01:13 2011 +0200
+       @@ -405,6 +405,10 @@
+                       if ($config{rcs}) {
+                               if (! $exists) {
+                                       rcs_add($file);
+       +                               $message = "add $file";
+       +                       }
+       +                       else {
+       +                               $message = "edit $file";
+                               }
+        
+                               # Prevent deadlock with post-commit hook by