Release checks v3

diff --git a/08/b9da1bac0cd3ae4d9b084e057d9930b4d8baf7 b/08/b9da1bac0cd3ae4d9b084e057d9930b4d8baf7
new file mode 100644 (file)
index 0000000..68032e2
--- /dev/null
+++ b/08/b9da1bac0cd3ae4d9b084e057d9930b4d8baf7
@@ -0,0 +1,150 @@
+Return-Path: <too@guru-group.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BCF7F431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Sep 2012 07:49:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id KK4xdBF8ymcy for <notmuch@notmuchmail.org>;\r
+       Tue,  4 Sep 2012 07:49:14 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8C411431FBD\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Sep 2012 07:49:14 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id BE7F310014E; Tue,  4 Sep 2012 17:49:20 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: notmuch@notmuchmail.org\r
+Subject: Release checks v3\r
+Date: Tue,  4 Sep 2012 17:49:11 +0300\r
+Message-Id: <1346770153-14947-1-git-send-email-tomi.ollila@iki.fi>\r
+X-Mailer: git-send-email 1.7.1\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Sep 2012 14:49:17 -0000\r
+\r
+This if V3 of release-check.sh patches, displacing\r
+\r
+id:"1346491928-2356-1-git-send-email-tomi.ollila@iki.fi"\r
+\r
+Changes:\r
+\r
+Bash kept, mainly for pipefail -- and that possible future pipeline \r
+additions have more protection.\r
+\r
+Added set -o posix lessens drifts to more bashishms -- and somewhere was \r
+mentioned that posix mode provides a bit more robust pipefail...\r
+\r
+Changed that one short circuit & continues to if... elif... fi construct.\r
+\r
+Used  *[^0-9.]*) for matching non-digit and non-dot characters; this\r
+was really nice one.\r
+\r
+One formatting change (added newline).\r
+\r
+Removed last 'exit 0'.\r
+\r
+---\r
+\r
+Something related: Some good pages for shell differences can be browsed at\r
+http://www.in-ulm.de/~mascheck/\r
+\r
+Diffdiff of the changes follows:\r
+\r
+--- v2/release-checks.sh\r
++++ v3/release-checks.sh\r
+@@ -10,13 +10,12 @@ then       echo\r
+       exit 1\r
+ fi\r
+ \r
++set -o posix\r
+ set -o pipefail # bash feature\r
+ \r
+ # Avoid locale-specific differences in output of executed commands\r
+ LANG=C LC_ALL=C; export LANG LC_ALL\r
+ \r
+-readonly DEFAULT_IFS="$IFS"\r
+-\r
+ readonly PV_FILE='bindings/python/notmuch/version.py'\r
+ \r
+ # Using array here turned out to be unnecessarily complicated\r
+@@ -28,9 +27,10 @@ append_emsg ()\r
+ \r
+ for f in ./version debian/changelog NEWS "$PV_FILE"\r
+ do\r
+-      test -f $f || { append_emsg "File '$f' is missing"; continue; }\r
+-      test -r $f || { append_emsg "File '$f' is unreadable"; continue; }\r
+-      test -s $f ||   append_emsg "File '$f' is empty"\r
++      if   [ ! -f "$f" ]; then append_emsg "File '$f' is missing"\r
++      elif [ ! -r "$f" ]; then append_emsg "File '$f' is unreadable"\r
++      elif [ ! -s "$f" ]; then append_emsg "File '$f' is empty"\r
++      fi\r
+ done\r
+ \r
+ if [ -n "$emsgs" ]\r
+@@ -62,18 +62,15 @@ verfail ()\r
+ }\r
+ \r
+ echo -n "Checking that '$VERSION' is good with digits and periods... "\r
+-if [ -z "${VERSION//[0123456789.]/}" ] # bash feature\r
+-then\r
+-      case $VERSION in\r
+-              .*)     verfail "'$VERSION' begins with a period" ;;\r
+-              *.)     verfail "'$VERSION' ends with a period" ;;\r
+-              *..*)   verfail "'$VERSION' contains two consecutive periods" ;;\r
+-              *.*)    echo Yes. ;;\r
+-              *)      verfail "'$VERSION' is a single number" ;;\r
+-      esac\r
+-else\r
+-      verfail "'$VERSION' contains other characters than digits and periods"\r
+-fi\r
++case $VERSION in\r
++      *[^0-9.]*)\r
++              verfail "'$VERSION' contains other characters than digits and periods" ;;\r
++      .*)     verfail "'$VERSION' begins with a period" ;;\r
++      *.)     verfail "'$VERSION' ends with a period" ;;\r
++      *..*)   verfail "'$VERSION' contains two consecutive periods" ;;\r
++      *.*)    echo Yes. ;;\r
++      *)      verfail "'$VERSION' is a single number" ;;\r
++esac\r
+ \r
+ \r
+ # In the rest of this file, tests collect list of errors to be fixed\r
+@@ -168,7 +165,9 @@ manfiles=`find man -type f | sort`\r
+ man_pages_ok=Yes\r
+ for mp in $manfiles\r
+ do\r
+-      case $mp in *.[0-9]) ;; # fall below this 'case ... esac'\r
++      case $mp in\r
++              *.[0-9]) ;; # fall below this 'case ... esac'\r
++\r
+               */Makefile.local | */Makefile ) continue ;;\r
+               */.gitignore)   continue ;;\r
+               *.bak)          continue ;;\r
+@@ -201,7 +200,6 @@ echo 'All checks this script executed completed successfully.'\r
+ echo 'Make sure that everything else mentioned in RELEASING'\r
+ echo 'file is in order, too.'\r
+ \r
+-exit 0\r
+ \r
+ # Local variables:\r
+ # mode: shell-script\r
+\r
+\r