Re: [PATCH 3/3] emacs: add notmuch hello refresh hook to display message count change

diff --git a/47/f1bc010f3d2d2c63cfa78b8d211e8f5cd6d228 b/47/f1bc010f3d2d2c63cfa78b8d211e8f5cd6d228
new file mode 100644 (file)
index 0000000..dcc1fcd
--- /dev/null
+++ b/47/f1bc010f3d2d2c63cfa78b8d211e8f5cd6d228
@@ -0,0 +1,155 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1814E431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  7 Jul 2012 23:57:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ESvES6RZMBoy for <notmuch@notmuchmail.org>;\r
+       Sat,  7 Jul 2012 23:57:26 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3A767431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  7 Jul 2012 23:57:26 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SnlQq-0006Kf-BJ; Sun, 08 Jul 2012 07:57:24 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SnlQq-0006OQ-0z; Sun, 08 Jul 2012 07:57:24 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/3] emacs: add notmuch hello refresh hook to display\r
+       message count change\r
+In-Reply-To:\r
+ <627aea74b0080dcd903b801042a4b2fd3868c049.1339775602.git.jani@nikula.org>\r
+References:\r
+ <37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org>\r
+       <627aea74b0080dcd903b801042a4b2fd3868c049.1339775602.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.13.2+61~gf708609 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 08 Jul 2012 07:57:20 +0100\r
+Message-ID: <87zk7aviy7.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 51b6354b5f1f903cb2c156519837ed22 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 08 Jul 2012 06:57:27 -0000\r
+\r
+On Fri, 15 Jun 2012, Jani Nikula <jani@nikula.org> wrote:\r
+> Add a notmuch hello refresh hook to display a message about change in\r
+> message count in the database since the notmuch-hello buffer was last\r
+> refreshed manually (no-display is nil).\r
+>\r
+> Signed-off-by: Jani Nikula <jani@nikula.org>\r
+\r
+Hi\r
+\r
+I just have a couple of comments/queries. First, since it breaks\r
+existing hooks I think it needs a NEWS item. \r
+\r
+Secondly, I, personally, would much prefer the hook with the slight\r
+tweak that it counts inbox messages rather than all messages. Is that\r
+an option that could be put in the defcustom?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> ---\r
+>  emacs/notmuch-hello.el |   27 +++++++++++++++++++++++++++\r
+>  1 file changed, 27 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index bc43178..bcca044 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -148,6 +148,7 @@ International Bureau of Weights and Measures."\r
+>  (defcustom notmuch-hello-refresh-hook nil\r
+>    "Functions called after updating a `notmuch-hello' buffer."\r
+>    :type 'hook\r
+> +  :options '(notmuch-hello-refresh-status-message)\r
+>    :group 'notmuch-hello\r
+>    :group 'notmuch-hooks)\r
+>  \r
+> @@ -749,6 +750,32 @@ following:\r
+>      (let ((fill-column (- (window-width) notmuch-hello-indent)))\r
+>        (center-region start (point)))))\r
+>  \r
+> +(defvar notmuch-hello-refresh-count 0\r
+> +  "Number of messages in the database when `notmuch-hello' was last run.\r
+> +\r
+> +Used internally by `notmuch-hello-refresh-status-message'.")\r
+> +\r
+> +(defun notmuch-hello-refresh-status-message (no-display)\r
+> +  "Hook to display a status message when refreshing notmuch-hello buffer.\r
+> +\r
+> +Display a status message about the difference in message count in\r
+> +the database since the last call."\r
+> +  (unless no-display\r
+> +    (let* ((new-count\r
+> +        (string-to-number (car (process-lines notmuch-command "count"))))\r
+> +       (diff-count (- new-count notmuch-hello-refresh-count)))\r
+> +      (cond\r
+> +       ((= notmuch-hello-refresh-count 0)\r
+> +    (message "You have %s messages."\r
+> +             (notmuch-hello-nice-number new-count)))\r
+> +       ((> diff-count 0)\r
+> +    (message "You have %s more messages since last refresh."\r
+> +             (notmuch-hello-nice-number diff-count)))\r
+> +       ((< diff-count 0)\r
+> +    (message "You have %s fewer messages since last refresh."\r
+> +             (notmuch-hello-nice-number (- diff-count)))))\r
+> +      (setq notmuch-hello-refresh-count new-count))))\r
+> +\r
+>  ;;;###autoload\r
+>  (defun notmuch-hello (&optional no-display)\r
+>    "Run notmuch and display saved searches, known tags, etc."\r
+> -- \r
+> 1.7.9.5\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r