Re: [PATCH] build: fix out-of-tree builds

diff --git a/e2/eae49311aeaf368d0fb9dea34483d57a86606d b/e2/eae49311aeaf368d0fb9dea34483d57a86606d
new file mode 100644 (file)
index 0000000..a86da25
--- /dev/null
+++ b/e2/eae49311aeaf368d0fb9dea34483d57a86606d
@@ -0,0 +1,79 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2E2F8431FC3\r
+       for <notmuch@notmuchmail.org>; Thu, 16 May 2013 04:16:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WKo6nTtS8uAk for <notmuch@notmuchmail.org>;\r
+       Thu, 16 May 2013 04:16:03 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B52A1431FC2\r
+       for <notmuch@notmuchmail.org>; Thu, 16 May 2013 04:16:03 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4GBFxWC017468;\r
+       Thu, 16 May 2013 08:16:00 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UcwAB-0004ZS-Dn; Thu, 16 May 2013 08:15:59 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UcwA5-0002TC-Ma; Thu, 16 May 2013 08:15:53 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] build: fix out-of-tree builds\r
+In-Reply-To: <874ne49pcm.fsf@nikula.org>\r
+References: <1368615519-25977-1-git-send-email-jani@nikula.org>\r
+       <87ehd8fdzg.fsf@zancas.localnet> <874ne49pcm.fsf@nikula.org>\r
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 16 May 2013 08:15:53 -0300\r
+Message-ID: <87hai3dvkm.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 16 May 2013 11:16:11 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> On Wed, 15 May 2013, David Bremner <david@tethera.net> wrote:\r
+>> Jani Nikula <jani@nikula.org> writes:\r
+>>>  # List all subdirectories here. Each contains its own Makefile.local\r
+>>> -subdirs := compat completion emacs lib man parse-time-string\r
+>>> -subdirs += performance-test util test\r
+>>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test\r
+>>\r
+>> Is this a functional change or a cosmetic one?\r
+>\r
+> Functional. All of it seems to be required for out-of-tree builds (*) to\r
+> work. I'm afraid I've forgotten exactly why both := and += make it fail\r
+> (I wrote the patch a few months ago).\r
+>\r
+\r
+Still I guess it deserves a comment so we don't break it again?\r
+\r
+d\r