[PATCH] emacs: jump: sort-order bugfix
authorMark Walters <markwalters1009@gmail.com>
Tue, 2 Sep 2014 12:30:49 +0000 (13:30 +0100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:04:24 +0000 (10:04 -0800)
ec/be5d9c09681e0f1cb8bb31ecf88448e6f451bf [new file with mode: 0644]

diff --git a/ec/be5d9c09681e0f1cb8bb31ecf88448e6f451bf b/ec/be5d9c09681e0f1cb8bb31ecf88448e6f451bf
new file mode 100644 (file)
index 0000000..72c8a26
--- /dev/null
@@ -0,0 +1,93 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E16D9431FDF\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Sep 2014 05:31:00 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id JEO38buxUjSj for <notmuch@notmuchmail.org>;\r
+       Tue,  2 Sep 2014 05:30:55 -0700 (PDT)\r
+Received: from mail-we0-f172.google.com (mail-we0-f172.google.com\r
+       [74.125.82.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3D00F431FD2\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Sep 2014 05:30:55 -0700 (PDT)\r
+Received: by mail-we0-f172.google.com with SMTP id q59so6886232wes.31\r
+       for <notmuch@notmuchmail.org>; Tue, 02 Sep 2014 05:30:53 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id;\r
+       bh=sHyZNKiIhoxIoGuHYtTk2j3+e5nJOsyhlKAF8fW2qVU=;\r
+       b=vG6D2cntY3SwC0xPytP0cyodH/TGf2uIVjV0THL/osm7qF0nScNRk52ehp+4i2O5FV\r
+       XVcX8F3L49eR9UmIKxl4k9aWDa8UA5xqQASF48C18ccocRFQvG1MgAIQZ53AJ6gRg5oz\r
+       KncFBAr1AE3Bm2lp+TRHPxByahWqgd0Mp0Cw3syXAfvmdTdnJeQaPKR6s72B0OovIYlp\r
+       8MGxTA0FJgpYQ3C/TYrVHauGAoDajg9WM1EHHBO+8NDm6CM21pRkh1YrAtR++ot9LVAA\r
+       dKGh2yw9aMOP3pCgYVdyzJzEGC/hSrAwx3LbBlC6zTB3c9VA729AEqDYxp4xA1XAP2yU\r
+       CT7A==\r
+X-Received: by 10.194.63.205 with SMTP id i13mr15999822wjs.74.1409661053875;\r
+       Tue, 02 Sep 2014 05:30:53 -0700 (PDT)\r
+Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])\r
+       by mx.google.com with ESMTPSA id n5sm9172874wja.38.2014.09.02.05.30.52\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Tue, 02 Sep 2014 05:30:53 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] emacs: jump: sort-order bugfix\r
+Date: Tue,  2 Sep 2014 13:30:49 +0100\r
+Message-Id: <1409661049-23417-1-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.10.4\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 02 Sep 2014 12:31:01 -0000\r
+\r
+default-value needs its argument to be quoted.\r
+---\r
+\r
+Slightly strangely default-value of 't or nil is 't or nil\r
+respectively so the code didn't give an error but just did the wrong\r
+thing.\r
+\r
+Thanks to Jani for finding the bug.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+ emacs/notmuch-jump.el |    2 +-\r
+ 1 file changed, 1 insertion(+), 1 deletion(-)\r
+\r
+diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el\r
+index 5eb0949..0193f8c 100644\r
+--- a/emacs/notmuch-jump.el\r
++++ b/emacs/notmuch-jump.el\r
+@@ -51,7 +51,7 @@ (defun notmuch-jump-search ()\r
+                (case (plist-get saved-search :sort-order)\r
+                  (newest-first nil)\r
+                  (oldest-first t)\r
+-                 (otherwise (default-value notmuch-search-oldest-first)))))\r
++                 (otherwise (default-value 'notmuch-search-oldest-first)))))\r
+           (push (list key name\r
+                       `(lambda () (notmuch-search ',query ',oldest-first)))\r
+                 action-map)))))\r
+-- \r
+1.7.10.4\r
+\r