--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 179F2431FBD\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:15:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id STwa1VODuvSB for <notmuch@notmuchmail.org>;\r
+ Mon, 12 May 2014 15:15:12 -0700 (PDT)\r
+Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com\r
+ [209.85.212.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id D7B6B431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:15:11 -0700 (PDT)\r
+Received: by mail-wi0-f172.google.com with SMTP id hi2so5286048wib.17\r
+ for <notmuch@notmuchmail.org>; Mon, 12 May 2014 15:15:10 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=haUlRsl5I4gB0MTYOFj+PVTx0a9xQTYJOYVHMh796IU=;\r
+ b=QTpf200px3QRpwAy1Wk3nLNCedXj71i2U+EKZUcxQczuJhCkQ0y8UNSaD/KbsDJnQ6\r
+ 62fGfCbRCaPOV9oMDOSHqcbDuPLZHUWioqN3tKRVTYpi28YHNuHelX0GDwdofFkAx0V5\r
+ CzuVm8MfxJ7HInRDFCkwbLUv2S4n6nFBnOpAhk74PuYgbOw2YqsYtY2AzEfsc3s+CQuR\r
+ MFQb+CsrQAUyMeIhPtqsoANCJMJLc96UplsY/Hbv+T/nF3M9/5pakeD/h0IJagjjNpP0\r
+ P5+uyAqofSkmfFZOOAmYQ7s8GvA0CaZET98dthmwBiC5fGQ4N7Wjel8bGdMSEdMPXBY9\r
+ WctA==\r
+X-Received: by 10.180.228.42 with SMTP id sf10mr17399220wic.33.1399932910682; \r
+ Mon, 12 May 2014 15:15:10 -0700 (PDT)\r
+Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])\r
+ by mx.google.com with ESMTPSA id\r
+ vm8sm19580727wjc.27.2014.05.12.15.15.09 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Mon, 12 May 2014 15:15:10 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 2/9] emacs/show: Allow the user to decide when part\r
+ headers should be inserted\r
+In-Reply-To: <1399897769-26809-3-git-send-email-dme@dme.org>\r
+References: <87sixdujkv.fsf@qmul.ac.uk>\r
+ <1399897769-26809-1-git-send-email-dme@dme.org>\r
+ <1399897769-26809-3-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 12 May 2014 23:15:07 +0100\r
+Message-ID: <87ppjik5jo.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 12 May 2014 22:15:20 -0000\r
+\r
+On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:\r
+> Make the function that determines whether a part header should be\r
+> inserted a user controlled, with some example functions.\r
+> ---\r
+> emacs/notmuch-show.el | 21 +++++++++++++++++++--\r
+> 1 file changed, 19 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index ec99141..f78a0ab 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -135,6 +135,17 @@ indentation."\r
+> :type 'boolean\r
+> :group 'notmuch-show)\r
+> \r
+> +(defcustom notmuch-show-insert-header-p-function 'notmuch-show-insert-header-p-smart\r
+> + "A function to call to determine whether a MIME part should have a header button.\r
+> +\r
+> +The function is passed one argument, PART - the MIME part in\r
+> +question."\r
+> + :type 'function\r
+> + :group 'notmuch-show\r
+> + :options '(notmuch-show-insert-header-p-smart\r
+> + notmuch-show-insert-header-p-always\r
+> + notmuch-show-insert-header-p-never))\r
+> +\r
+\r
+I think this is nice as a defcustom for testing/seeing what happens, but I am\r
+not sure we want it exposed longer term: for example never makes it\r
+nearly impossible to view pdf parts.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+> (defvar notmuch-show-thread-id nil)\r
+> (make-variable-buffer-local 'notmuch-show-thread-id)\r
+> (put 'notmuch-show-thread-id 'permanent-local t)\r
+> @@ -880,12 +891,18 @@ message at DEPTH in the current thread."\r
+> "text/x-diff")\r
+> content-type)))\r
+> \r
+> -(defun notmuch-show-insert-header-p (part)\r
+> +(defun notmuch-show-insert-header-p-smart (part)\r
+> "Return non-NIL if a header button should be inserted for this part."\r
+> (let ((mime-type (notmuch-show-mime-type part)))\r
+> (not (and (string= mime-type "text/plain")\r
+> (<= (plist-get part :id) 1)))))\r
+> \r
+> +(defun notmuch-show-insert-header-p-always (part)\r
+> + t)\r
+> +\r
+> +(defun notmuch-show-insert-header-p-never (part)\r
+> + nil)\r
+> +\r
+> (defun notmuch-show-insert-bodypart (msg part depth &optional hide)\r
+> "Insert the body part PART at depth DEPTH in the current thread.\r
+> \r
+> @@ -904,7 +921,7 @@ useful for quoting in replies)."\r
+> ;; We omit the part button for the first (or only) part if\r
+> ;; this is text/plain, or HIDE is 'no-buttons.\r
+> (button (when (and (not (equal hide 'no-buttons))\r
+> - (notmuch-show-insert-header-p part))\r
+> + (funcall notmuch-show-insert-header-p-function part))\r
+> (notmuch-show-insert-part-header nth mime-type content-type (plist-get part :filename))))\r
+> (content-beg (point)))\r
+> \r
+> -- \r
+> 2.0.0.rc0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff