Re: [PATCH] man/Makefile.local: allow out-of-tree 'make install'.
authorRory Yorke <rory.yorke@gmail.com>
Sun, 4 Aug 2013 12:36:38 +0000 (14:36 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:56:14 +0000 (09:56 -0800)
36/19e24c2f6541c06009e9a889efc0e96bf974ef [new file with mode: 0644]

diff --git a/36/19e24c2f6541c06009e9a889efc0e96bf974ef b/36/19e24c2f6541c06009e9a889efc0e96bf974ef
new file mode 100644 (file)
index 0000000..2eec256
--- /dev/null
@@ -0,0 +1,148 @@
+Return-Path: <rory.yorke@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 28228431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  4 Aug 2013 05:36:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fb5w8WRBHE1x for <notmuch@notmuchmail.org>;\r
+       Sun,  4 Aug 2013 05:36:46 -0700 (PDT)\r
+Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com\r
+       [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 388FC431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  4 Aug 2013 05:36:46 -0700 (PDT)\r
+Received: by mail-ea0-f181.google.com with SMTP id d10so1132527eaj.12\r
+       for <notmuch@notmuchmail.org>; Sun, 04 Aug 2013 05:36:43 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=lCtEANNKzKmfPRoeTdqWq6ewuZZ5f1U6yig6gl9ou+8=;\r
+       b=lWZfgE4HQu6LoaKCcbrZKurlNxFzRRN9WCxDtLlkpZhtMgNAr0cLinr6oQXRCPfxYE\r
+       7a0t3SyayI2OT06rCi4/Ql1r4oD8aNKk7UcQIUbO7ZAT6TMec5qWlhV9rkmEuZYWqeh9\r
+       fRquvLuZ0TzoOWRUgYzgr4yTZ1U7Z0xE3gT8usYWg3HYWpHuJ49Dt+Ak9D9rZ6ldeIky\r
+       JZDjGOpdtsc2xa0c7fmBdT/KVfx6zQk/+iI1DshNRj6/CRshBQa/l67WqosUhsBSMgB0\r
+       srXrevURIBH5C3fg4d56CGynTKuhyzzhjmODekzHnZUCL71vVJotliqj1UUPmTQ3fAVi\r
+       vuRQ==\r
+X-Received: by 10.15.83.69 with SMTP id b45mr12638780eez.150.1375619803649;\r
+       Sun, 04 Aug 2013 05:36:43 -0700 (PDT)\r
+Received: from rory-Inspiron-3521 (ti-225-82-132.telkomadsl.co.za.\r
+       [105.225.82.132])\r
+       by mx.google.com with ESMTPSA id k7sm9399568eeg.13.2013.08.04.05.36.41\r
+       for <multiple recipients>\r
+       (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\r
+       Sun, 04 Aug 2013 05:36:42 -0700 (PDT)\r
+Received: from rory-Inspiron-3521 (localhost [127.0.0.1])\r
+       by rory-Inspiron-3521 (Postfix) with ESMTP id 43C1E16001C1;\r
+       Sun,  4 Aug 2013 14:36:38 +0200 (SAST)\r
+From: Rory Yorke <rory.yorke@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] man/Makefile.local: allow out-of-tree 'make install'.\r
+In-Reply-To: <m2mwoy32da.fsf@guru.guru-group.fi>\r
+References: <1375522597-23428-1-git-send-email-rory.yorke@gmail.com>\r
+       <m2mwoy32da.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 04 Aug 2013 14:36:38 +0200\r
+Message-ID: <871u69pr8p.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 04 Aug 2013 12:36:51 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> So why $(srcdir)/ prefix is needed only here...\r
+\r
+Hi,\r
+\r
+I'm not sure; I'm afraid I just did something that worked for me.  It\r
+was long enough ago that I don't remember how I came up with this\r
+hack. \r
+\r
+Here's what appears to be some pertinent different behaviour between\r
+master and my patch:\r
+\r
+1. In empty directory ~/tmp/notmuch-build-master run ~/git/notmuch/configure, with ~/git/notmuch checked out as master:\r
+2. Partial output of make -d -n install is:\r
+\r
+    Considering target file `man/man1/notmuch-tag.1.gz'.\r
+     File `man/man1/notmuch-tag.1.gz' does not exist.\r
+     Looking for an implicit rule for `man/man1/notmuch-tag.1.gz'.\r
+     Trying pattern rule with stem `notmuch-tag.1'.\r
+     Trying implicit prerequisite `man/man1/notmuch-tag.1'.\r
+     Found prerequisite `man/man1/notmuch-tag.1' as VPATH `/home/rory/git/notmuch/man/man1/notmuch-tag.1'\r
+[many lines omitted]\r
+    Must remake target `man/man1/notmuch-tag.1.gz'.\r
+gzip --stdout /home/rory/git/notmuch/man/man1/notmuch-tag.1 > man/man1/notmuch-tag.1.gz\r
+    Successfully remade target file `man/man1/notmuch-tag.1.gz'.\r
+    Considering target file `man/man5/notmuch-hooks.5.gz'.\r
+     File `man/man5/notmuch-hooks.5.gz' does not exist.\r
+     Looking for an implicit rule for `man/man5/notmuch-hooks.5.gz'.\r
+     Trying pattern rule with stem `notmuch-hooks.5'.\r
+     Trying implicit prerequisite `man/man5/notmuch-hooks.5'.\r
+     Trying pattern rule with stem `notmuch-hooks.5.gz'.\r
+     Trying implicit prerequisite `man/man5/notmuch-hooks.5.gz,v'.\r
+[many lines omitted]\r
+    Must remake target `man/man5/notmuch-hooks.5.gz'.\r
+make: *** No rule to make target `man/man5/notmuch-hooks.5.gz', needed by `install-man'.  Stop.\r
+\r
+3. In empty directory ~/tmp/notmuch-build-rory run ~/git/notmuch/configure, with ~/git/notmuch checked out as rory.\r
+4. Partial output of make -d -n install is:\r
+\r
+    Considering target file `/home/rory/git/notmuch/man/man1/notmuch-tag.1.gz'.\r
+     File `/home/rory/git/notmuch/man/man1/notmuch-tag.1.gz' does not exist.\r
+     Looking for an implicit rule for `/home/rory/git/notmuch/man/man1/notmuch-tag.1.gz'.\r
+     Trying pattern rule with stem `notmuch-tag.1'.\r
+     Trying implicit prerequisite `/home/rory/git/notmuch/man/man1/notmuch-tag.1'.\r
+     Found an implicit rule for `/home/rory/git/notmuch/man/man1/notmuch-tag.1.gz'.\r
+[many lines omitted]\r
+    Must remake target `/home/rory/git/notmuch/man/man1/notmuch-tag.1.gz'.\r
+gzip --stdout /home/rory/git/notmuch/man/man1/notmuch-tag.1 > /home/rory/git/notmuch/man/man1/notmuch-tag.1.gz\r
+    Successfully remade target file `/home/rory/git/notmuch/man/man1/notmuch-tag.1.gz'.\r
+    Considering target file `/home/rory/git/notmuch/man/man5/notmuch-hooks.5.gz'.\r
+     File `/home/rory/git/notmuch/man/man5/notmuch-hooks.5.gz' does not exist.\r
+     Looking for an implicit rule for `/home/rory/git/notmuch/man/man5/notmuch-hooks.5.gz'.\r
+     Trying pattern rule with stem `notmuch-hooks.5'.\r
+     Trying implicit prerequisite `/home/rory/git/notmuch/man/man5/notmuch-hooks.5'.\r
+     Found an implicit rule for `/home/rory/git/notmuch/man/man5/notmuch-hooks.5.gz'.\r
+[many lines omitted]\r
+    Must remake target `/home/rory/git/notmuch/man/man5/notmuch-hooks.5.gz'.\r
+gzip --stdout /home/rory/git/notmuch/man/man5/notmuch-hooks.5 > /home/rory/git/notmuch/man/man5/notmuch-hooks.5.gz\r
+\r
+The successful build of notmuch-tag.1.gz is *different* -- on master\r
+VPATH is used, while with my patch it is not.\r
+\r
+The rules for man1, man5 and man7 certainly look similar, so it's not\r
+clear why the man1 entries work.  Perhaps this fragment at the top of\r
+man/Makefile.local is there for a similar reason?\r
+\r
+  # this variable seems to be needed to prevent lazy evaluation causing\r
+  # problems with $(dir) changing values.\r
+  MAIN_PAGE := $(dir)/man1/notmuch.1\r
+\r
+I see the gzipped man files end up in the source tree; I guess ideally\r
+they'd be in the build tree?\r
+\r
+Regards,\r
+\r
+Rory\r