Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input...

diff --git a/83/2681949454dfdde37a24bf871e4ea67de50ae4 b/83/2681949454dfdde37a24bf871e4ea67de50ae4
new file mode 100644 (file)
index 0000000..ea39836
--- /dev/null
+++ b/83/2681949454dfdde37a24bf871e4ea67de50ae4
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1D635431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  7 Mar 2013 06:39:05 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id BtJJ2id0woBB for <notmuch@notmuchmail.org>;\r
+       Thu,  7 Mar 2013 06:39:04 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 12F24431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  7 Mar 2013 06:39:04 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 1AA57100051;\r
+       Thu,  7 Mar 2013 16:38:53 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new"\r
+       parameter input only\r
+In-Reply-To: <87boavxr1u.fsf@zancas.localnet>\r
+References: <cover.1362347362.git.jani@nikula.org>\r
+       <5faebfc5d36d7e85a4dd1acbca0417d8a6a2602d.1362347362.git.jani@nikula.org>\r
+       <87boavxr1u.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15.2+50~g43fdda5 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 07 Mar 2013 16:38:52 +0200\r
+Message-ID: <m26213nukj.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 07 Mar 2013 14:39:05 -0000\r
+\r
+On Thu, Mar 07 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> We now have a notmuch_config_is_new() function to query whether a\r
+>> config was created or not. Change the notmuch_config_open() is_new\r
+>> parameter into boolean create_new to determine whether the function\r
+>> should create a new config if one doesn't exist. This reduces the\r
+>> complexity of the API.\r
+>\r
+> I have pushed the first 4 patches in this series. I'd like a second\r
+> (third?) pair of eyes on 5/6.\r
+\r
+The changes in 5/6 (and 6/6 & manpage) LGTM. Using config for the context\r
+is good. The reply context of this mail has been produced by notmuch\r
+with these patches applied.\r
+\r
+> d\r
+\r
+Tomi\r