Re: [Patch v2 04/13] lib/cli: add library API / CLI for compile time options

diff --git a/37/7af0593f683eece2d2be03cadb735e055bcf57 b/37/7af0593f683eece2d2be03cadb735e055bcf57
new file mode 100644 (file)
index 0000000..27360c6
--- /dev/null
+++ b/37/7af0593f683eece2d2be03cadb735e055bcf57
@@ -0,0 +1,87 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 7A4886DE02AD\r
+ for <notmuch@notmuchmail.org>; Sun,  1 May 2016 10:49:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.606\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.606 tagged_above=-999 required=5 tests=[AWL=-0.046,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id QQtYWX3XcZIu for <notmuch@notmuchmail.org>;\r
+ Sun,  1 May 2016 10:49:09 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id C6E8E6DE01BE\r
+ for <notmuch@notmuchmail.org>; Sun,  1 May 2016 10:49:08 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id E322A10004A\r
+ for <notmuch@notmuchmail.org>; Sun,  1 May 2016 20:48:53 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 04/13] lib/cli: add library API / CLI for compile time\r
+ options\r
+In-Reply-To: <87inyz8g8f.fsf@zancas.localnet>\r
+References: <1459015043-8460-1-git-send-email-david@tethera.net>\r
+ <1459015043-8460-5-git-send-email-david@tethera.net>\r
+ <m27ffjvt9j.fsf@guru.guru-group.fi> <87inyz8g8f.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.22+9~gb26b5ad (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 01 May 2016 20:48:53 +0300\r
+Message-ID: <m2mvo94qka.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 01 May 2016 17:49:17 -0000\r
+\r
+On Sat, Apr 30 2016, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> On Sat, Mar 26 2016, David Bremner <david@tethera.net> wrote:\r
+>>\r
+>>\r
+>> ... note: if this notmuch_options_present () function prevails, fix\r
+>> the later #if check ;D\r
+>>\r
+>> ... and\r
+>>\r
+>> void\r
+>> _notmuch_config_list_options () {\r
+>>     printf("options.compact=%s\n",\r
+>>        HAVE_XAPIAN_COMPACT ? "true" : "false");\r
+>>     printf("options.field_processor=%s\n",\r
+>>        HAVE_XAPIAN_FIELD_PROCESSOR ? "true" : "false");\r
+>> }\r
+>>\r
+>\r
+> This I'm not so sure about. There's a subtle distinction between what is\r
+> supported in the CLI and what is supported in the lib, and we really\r
+> want the latter. So I do think _some_ library routine is needed.\r
+\r
+Ah! this is the one thing I did not catch -- we need to know what _library_\r
+supports from cli/bindings/whatnot. This makes most of the things I wrote\r
+in my email irrelevant ;/ \r
+\r
+You seem to have sent new series so I stop commenting this and concentrate\r
+on that...\r
+\r
+Tomi\r
+\r