[PATCH v3 0/4] cli: notmuch tag/restore refactoring

diff --git a/95/b2cd0f409583cdaf79b32eb76c811243382835 b/95/b2cd0f409583cdaf79b32eb76c811243382835
new file mode 100644 (file)
index 0000000..0d8e579
--- /dev/null
+++ b/95/b2cd0f409583cdaf79b32eb76c811243382835
@@ -0,0 +1,92 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6ED25431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 14:04:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8pP24oP8PnjY for <notmuch@notmuchmail.org>;\r
+       Mon, 26 Mar 2012 14:04:18 -0700 (PDT)\r
+Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A4201431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 14:04:17 -0700 (PDT)\r
+Received: by lahc1 with SMTP id c1so4613102lah.26\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 14:04:15 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state;\r
+       bh=CE/+Cq47IMYPm/Gmgtd9+KR+F6FE1TZ6GlzmSmn1yxY=;\r
+       b=XEBRj/ufp+whICzdTr6tiQVMN9GTGxLiu+kBJRRV1C+8KC88LtE7CGe3N+w8IBnbi4\r
+       tmPcwoQ/+uxSfiZPbQ9UTKuuC7IDnV2/WRMeWqFjpZ0okZTYSGl7WJLP0wiMQldAEsss\r
+       1kGb8eWuy/4agIvtYXtk0s6eukBxvVhUZMKxLNfw+u3zqjfGKJbPnnAP5LTAJTVIVpB2\r
+       DbSHx9bmAgCz1VpZLOftz9hWWKn9+rMh8HMAJx9SYFSHSqv5QTGRhakiqwPf/D2DYell\r
+       AFysQ+YDPzwQV/8MwmZy64AtxBRl7ctDEXnMqj3rpRuTdk8MuuuVgI0Q8HCdBvsAg3Il\r
+       8+2w==\r
+Received: by 10.112.38.68 with SMTP id e4mr8695822lbk.38.1332795855788;\r
+       Mon, 26 Mar 2012 14:04:15 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi.\r
+       [84.248.80.253])\r
+       by mx.google.com with ESMTPS id p9sm23268459lbw.10.2012.03.26.14.04.13\r
+       (version=SSLv3 cipher=OTHER); Mon, 26 Mar 2012 14:04:14 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v3 0/4] cli: notmuch tag/restore refactoring\r
+Date: Tue, 27 Mar 2012 00:04:07 +0300\r
+Message-Id: <cover.1332795415.git.jani@nikula.org>\r
+X-Mailer: git-send-email 1.7.5.4\r
+X-Gm-Message-State:\r
+ ALoCoQkfwigDEkrFvZHEywTq0xnvRXWZJF03iwoE0AzBre8aVIugHWnsEQJnCyZY9Q3cC6Gpfm61\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Mar 2012 21:04:18 -0000\r
+\r
+v3 of id:"cover.1332702915.git.jani@nikula.org" with the following\r
+mostly non-functional changes:\r
+\r
+ - add test for the current tagging behaviour in patch 1, and change the\r
+   test in patch 2 when the behaviour is changed\r
+ - handle the no tag changes case in _optimize_tag_query() in patch 2\r
+ - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');"\r
+   assignment\r
+ - document the tag_query() function a bit in patch 3\r
+ - make tag_message() static in patch 4\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+Jani Nikula (4):\r
+  test: add test for both adding and removing a tag at the same time\r
+  cli: refactor "notmuch tag" data structures for tagging operations\r
+  cli: refactor "notmuch tag" query tagging into a separate function\r
+  cli: refactor "notmuch restore" message tagging into a separate\r
+    function\r
+\r
+ notmuch-restore.c |  148 ++++++++++++++++++++++++---------------------\r
+ notmuch-tag.c     |  173 ++++++++++++++++++++++++++++-------------------------\r
+ test/tagging      |    8 +++\r
+ 3 files changed, 178 insertions(+), 151 deletions(-)\r
+\r
+-- \r
+1.7.5.4\r
+\r