Re: [PATCH] dump: make dump take Xapian write lock

diff --git a/6a/0328384ec951160848cfaa1042f74fdbe0d1d9 b/6a/0328384ec951160848cfaa1042f74fdbe0d1d9
new file mode 100644 (file)
index 0000000..b1ea55d
--- /dev/null
+++ b/6a/0328384ec951160848cfaa1042f74fdbe0d1d9
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5DCDA431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 15:36:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 82E3RiFPkvjV for <notmuch@notmuchmail.org>;\r
+       Wed, 16 Jul 2014 15:36:40 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A0F36431FC9\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 15:36:40 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1X7XoV-0008VO-Ds; Wed, 16 Jul 2014 19:36:39 -0300\r
+Received: (nullmailer pid 29658 invoked by uid 1000); Wed, 16 Jul 2014\r
+       22:36:35 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] dump: make dump take Xapian write lock\r
+In-Reply-To: <1403554349-8888-1-git-send-email-markwalters1009@gmail.com>\r
+References: <87zjhh67e7.fsf@qmul.ac.uk>\r
+       <1403554349-8888-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.18.1+45~gf47eeac (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 16 Jul 2014 19:36:35 -0300\r
+Message-ID: <878unt7wy4.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 16 Jul 2014 22:36:45 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> Dump currently only takes the read lock. Xapian can cope with some\r
+> changes while maintaining a read snapshot but with more changes it\r
+> fails. Currently notmuch just gives a xapian error.\r
+>\r
+> To avoid this we take the write lock when dumping. This prevents other\r
+> notmuch processes from modifying the xapian database preventing this\r
+> error.\r
+\r
+pushed. This needs a NEWS item.\r
+\r
+d\r