Re: [bug] notmuch requires Content-Disposition mime header value to be lower case

diff --git a/20/84d8a74e2162e04caf6933d5ad5d77dde0d570 b/20/84d8a74e2162e04caf6933d5ad5d77dde0d570
new file mode 100644 (file)
index 0000000..6f04378
--- /dev/null
+++ b/20/84d8a74e2162e04caf6933d5ad5d77dde0d570
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id B945D6DE140B\r
+ for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 06:27:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.114\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id vthQs6nv3g0V for <notmuch@notmuchmail.org>;\r
+ Fri, 18 Sep 2015 06:27:12 -0700 (PDT)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id F3B236DE0AF8\r
+ for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 06:27:11 -0700 (PDT)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1Zcvg6-0001Tj-Gu; Fri, 18 Sep 2015 13:26:14 +0000\r
+Received: (nullmailer pid 21542 invoked by uid 1000); Fri, 18 Sep 2015\r
+ 13:26:00 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Johannes Schauer <josch@debian.org>, notmuch@notmuchmail.org\r
+Subject: Re: [bug] notmuch requires Content-Disposition mime header value to\r
+ be lower case\r
+In-Reply-To: <20150918123724.1941.3900@localhost>\r
+References: <20150917070056.1941.94846@localhost>\r
+ <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost>\r
+ <87pp1grl2v.fsf@maritornes.cs.unb.ca> <20150918123724.1941.3900@localhost>\r
+User-Agent: Notmuch/0.20.2+61~g005c2f0 (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 18 Sep 2015 10:26:00 -0300\r
+Message-ID: <871tdvvoyf.fsf@tesseract.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 18 Sep 2015 13:27:13 -0000\r
+\r
+Johannes Schauer <josch@debian.org> writes:\r
+\r
+> Hi,\r
+>\r
+> Quoting David Bremner (2015-09-18 14:03:20)\r
+>> I'd recommend making your own new test, rather than modifying existing\r
+>> ones to test multiple things.  I'd also recommend using json / sexp\r
+>> output for your tests, since the ad-hoc text format is kindof\r
+>> semi-deprecated.\r
+>\r
+> can you take care of that? My goal was actually just to report this bug, not to\r
+> spend more time to develop a proper patch for it :)\r
+\r
+Consider the bug reported. At the moment I'm not completely convinced\r
+the patch is correct, never mind the tests. I agree it looks obvious\r
+enough, but the test results don't make sense to me yet.\r
+\r
+>\r
+> Also, a related problem occurs when the Content-Disposition header contains\r
+> UTF8 characters, in which case the header value gets encoded. Apparently\r
+> notmuch does not attempt to decode it. Example mime header:\r
+>\r
+> --===============7161366892858136962==\r
+> Content-Type: application/pdf\r
+> MIME-Version: 1.0\r
+> Content-Transfer-Encoding: base64\r
+> Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?=\r
+>  =?utf-8?b?LnBkZiI=?=\r
+\r
+yes, that sounds like a distinct bug.\r