Re: [PATCH] emacs: show: let the user override the mime-type of an attachment

diff --git a/c6/6434e69b289c290f5b6e43858accffe40935ca b/c6/6434e69b289c290f5b6e43858accffe40935ca
new file mode 100644 (file)
index 0000000..657f394
--- /dev/null
+++ b/c6/6434e69b289c290f5b6e43858accffe40935ca
@@ -0,0 +1,69 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 055FE6DE1585\r
+ for <notmuch@notmuchmail.org>; Sat,  1 Aug 2015 13:48:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.147\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.147 tagged_above=-999 required=5 tests=[AWL=0.147]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id SR5qXoKWle5m for <notmuch@notmuchmail.org>;\r
+ Sat,  1 Aug 2015 13:48:51 -0700 (PDT)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id CF4256DE1533\r
+ for <notmuch@notmuchmail.org>; Sat,  1 Aug 2015 13:48:50 -0700 (PDT)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ZLdgg-0006oJ-JR; Sat, 01 Aug 2015 20:47:22 +0000\r
+Received: (nullmailer pid 30970 invoked by uid 1000); Sat, 01 Aug 2015\r
+ 20:47:08 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: show: let the user override the mime-type of an\r
+ attachment\r
+In-Reply-To: <1435702585-27363-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1435702585-27363-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Aug 2015 22:47:08 +0200\r
+Message-ID: <87mvyaenxv.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Aug 2015 20:48:54 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> +(defun notmuch-show-internal-mm-display-part (handle)\r
+\r
+It's very much a quibble, but I don't understand the naming scheme\r
+here. Is internal meant to denote an privateish function? If so the\r
+convention of using -- (notmuch-show--mm-display-part, I guess) seems\r
+more common in the code base. Or does internal/external refer to viewers\r
+here?\r
+\r
+Otherwise, it looks good. The only thing that I really missed was\r
+completion on mime types. But that makes sense as a seperate patch, even\r
+if it is easy, and I have no idea how easy it is.\r
+\r
+d\r
+\r
+\r
+\r
+\r