vcs-svn: suppress a signed/unsigned comparison warning
authorDavid Barr <davidbarr@google.com>
Thu, 31 May 2012 14:41:29 +0000 (00:41 +1000)
committerJonathan Nieder <jrnieder@gmail.com>
Fri, 6 Jul 2012 04:26:53 +0000 (23:26 -0500)
The preceding code checks that view->max_off is nonnegative and
(off + width) fits in an off_t, so this code is already safe.

Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
vcs-svn/sliding_window.c

index ec2707c9c421424a8b34f456aa7472c4c0f45559..f11d490995ee7e3367c1d18e1058f2e322cfa177 100644 (file)
@@ -54,7 +54,7 @@ int move_window(struct sliding_view *view, off_t off, size_t width)
                return -1;
        if (off < view->off || off + width < view->off + view->width)
                return error("invalid delta: window slides left");
-       if (view->max_off >= 0 && view->max_off < off + width)
+       if (view->max_off >= 0 && view->max_off < off + (off_t) width)
                return error("delta preimage ends early");
 
        file_offset = view->off + view->buf.len;