Why didn't we mark want_obj as ~UNINTERESTING in the old code?

Is this something we would want to do regardless of shallow clone?

diff --git a/upload-pack.c b/upload-pack.c
index 4a9d6720a5a0e9977bd9346e649666ead4e18fe4..7e3c437d8e1eaca61ccabb29f3097ba9c5c3732e 100644 (file)
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -138,6 +138,7 @@ static void create_pack_file(void)
                } else {
                        for (i = 0; i < want_obj.nr; i++) {
                                struct object *o = want_obj.objects[i].item;
+                               /* why??? */
                                o->flags &= ~UNINTERESTING;
                                add_pending_object(&revs, o, NULL);
                        }